From owner-freebsd-current@FreeBSD.ORG Mon Jun 15 08:45:27 2009 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 9F8E11065672 for ; Mon, 15 Jun 2009 08:45:27 +0000 (UTC) (envelope-from pyunyh@gmail.com) Received: from wa-out-1112.google.com (wa-out-1112.google.com [209.85.146.180]) by mx1.freebsd.org (Postfix) with ESMTP id 6D48A8FC1E for ; Mon, 15 Jun 2009 08:45:27 +0000 (UTC) (envelope-from pyunyh@gmail.com) Received: by wa-out-1112.google.com with SMTP id m38so1209429waf.27 for ; Mon, 15 Jun 2009 01:45:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:received:from:date:to:cc :subject:message-id:reply-to:references:mime-version:content-type :content-disposition:in-reply-to:user-agent; bh=2JS+UGgHqf1kjGiTR3k2z+OofxRAp+k1ZnpuN6GTOIA=; b=aHfolWxR7VjF7CrrKzeXc1wxPY7Q+woZEO2Mt3lWG6NBAfeKTSrKQheR3lH6sIjAFv 2VllGcNm3sxGb7pgI5o2SR9vtbtYRxJYRcr6ZtPIjRtzmSeNpJ+0ChI3O2PhDrn++9VM Yv2D1mS3IfMNWhO8OqxYquzcwqLJd7HdtMZB0= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:date:to:cc:subject:message-id:reply-to:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; b=PITgmTQJp/wGTBKTDjS94iyHk56NBnZQ3LAka0Xg1dw/oamZzzTDeCLGxd5xywzsuU N/6dzo0VJjK8mmoISX5Mx122Oqt5zpAWsFUvIQVUOMjwigf7cbH9q1KPxFds9G6tKn+l +AVudLVqcJd1q/nwhpwFora5+hhxH5mP6WmGI= Received: by 10.114.159.6 with SMTP id h6mr11360706wae.19.1245055526772; Mon, 15 Jun 2009 01:45:26 -0700 (PDT) Received: from michelle.cdnetworks.co.kr ([114.111.62.249]) by mx.google.com with ESMTPS id j39sm5822054waf.45.2009.06.15.01.45.25 (version=SSLv3 cipher=RC4-MD5); Mon, 15 Jun 2009 01:45:26 -0700 (PDT) Received: by michelle.cdnetworks.co.kr (sSMTP sendmail emulation); Mon, 15 Jun 2009 17:48:50 +0900 From: Pyun YongHyeon Date: Mon, 15 Jun 2009 17:48:50 +0900 To: Bruce Simpson Message-ID: <20090615084850.GD78415@michelle.cdnetworks.co.kr> References: <20090615044106.GC78415@michelle.cdnetworks.co.kr> <4A36018E.2050301@incunabulum.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4A36018E.2050301@incunabulum.net> User-Agent: Mutt/1.4.2.3i Cc: freebsd-current@freebsd.org Subject: Re: CFT: fxp(4) X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: pyunyh@gmail.com List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Jun 2009 08:45:27 -0000 On Mon, Jun 15, 2009 at 09:08:46AM +0100, Bruce Simpson wrote: > Pyun YongHyeon wrote: > >Please test the patch in the following URL if you have fxp(4) > >hardwares. The patch contains various accumulated fixes for > >multicast handling, bus_dma fixes, more sane initialization > >and enhanced lockup detection for buggy controllers. > > This is just a note to say that I *have* observed problems with > multicast setup in fxp(4) -- it seems to need setting up of the > link-layer hash filter for a group to transmit as well as receive. > I couldn't see this limitation in datasheet. So it could be a bug in stock fxp(4). > This isn't OK, NICs should be able to transmit w/o receive setup, and > may break normal use-cases (esp. IPv6), I posted to freebsd-net@ about > this over the past 12 months, but did not have time to reproduce or > isolate the issue. So a fix is very, very welcome. Thanks for working on > this. So does that patch fixed the issue? I'm not familiar with multicasting but I did my best to make fxp(4) work on multicasting environments. fxp(4) hardwares do not allow multicast hash filter programming when device is not in idle state. So stock fxp(4) used to rely on Tx completion interrupt to program multicast filters. I think that is error-prone/complex and fxp(4) can drop multicat frames until its filter is fully reprogrammed. > > I have an fxp(4) but it's in my home server RELENG_7 box... any plans to > backport? > Yeah, if the patch works. > thanks, > BMS