From owner-freebsd-ports-bugs@FreeBSD.ORG Tue Mar 9 00:40:04 2010 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 1AEEF106566B for ; Tue, 9 Mar 2010 00:40:04 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id D2AB08FC1B for ; Tue, 9 Mar 2010 00:40:03 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id o290e37d074880 for ; Tue, 9 Mar 2010 00:40:03 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id o290e3X0074878; Tue, 9 Mar 2010 00:40:03 GMT (envelope-from gnats) Resent-Date: Tue, 9 Mar 2010 00:40:03 GMT Resent-Message-Id: <201003090040.o290e3X0074878@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Benjamin Lee Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8313F106566B for ; Tue, 9 Mar 2010 00:35:29 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21]) by mx1.freebsd.org (Postfix) with ESMTP id 72B848FC18 for ; Tue, 9 Mar 2010 00:35:29 +0000 (UTC) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.14.3/8.14.3) with ESMTP id o290ZSiv041174 for ; Tue, 9 Mar 2010 00:35:29 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.14.3/8.14.3/Submit) id o290ZSBK041172; Tue, 9 Mar 2010 00:35:28 GMT (envelope-from nobody) Message-Id: <201003090035.o290ZSBK041172@www.freebsd.org> Date: Tue, 9 Mar 2010 00:35:28 GMT From: Benjamin Lee To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: ports/144567: graphics/gd WITH_FONTCONFIG and WITHOUT_X11 are not exclusive X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Mar 2010 00:40:04 -0000 >Number: 144567 >Category: ports >Synopsis: graphics/gd WITH_FONTCONFIG and WITHOUT_X11 are not exclusive >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Tue Mar 09 00:40:03 UTC 2010 >Closed-Date: >Last-Modified: >Originator: Benjamin Lee >Release: 8.0-RELEASE-p2 >Organization: >Environment: FreeBSD eclipse.b1c1l1.com 8.0-RELEASE-p2 FreeBSD 8.0-RELEASE-p2 #0: Tue Jan 5 16:02:27 UTC 2010 root@i386-builder.daemonology.net:/usr/obj/usr/src/sys/GENERIC i386 >Description: Currently, the graphics/gd port can only build with fontconfig support (via the WITH_FONTCONFIG knob) if WITHOUT_X11 is not defined. This is an unnecessary restriction, as gd can build with fontconfig support on machine built with WITHOUT_X11 defined. >How-To-Repeat: Build graphics/gd with both WITHOUT_X11 and WITH_FONTCONFIG defined. >Fix: Apply the attached patch. Patch attached with submission follows: --- /usr/ports/graphics/gd/Makefile 2010-02-05 03:38:31.000000000 -0800 +++ Makefile 2010-03-08 16:30:11.000000000 -0800 @@ -50,6 +50,8 @@ FEATURES+= GD_XPM .endif +.endif + .if defined(WITH_FONTCONFIG) LIB_DEPENDS+= fontconfig.1:${PORTSDIR}/x11-fonts/fontconfig CPPFLAGS+= -I${LOCALBASE}/include -DHAVE_LIBFONTCONFIG -DHAVE_PTHREAD ${PTHREAD_CFLAGS} @@ -58,8 +60,6 @@ FEATURES+= GD_FONTCONFIG .endif -.endif - .if defined(WITH_ICONV) USE_ICONV= yes CPPFLAGS+= -DHAVE_ICONV -DHAVE_ICONV_H -DHAVE_ICONV_T_DEF >Release-Note: >Audit-Trail: >Unformatted: