From owner-svn-src-all@FreeBSD.ORG Thu Jul 10 21:39:55 2014 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 7E67B654 for ; Thu, 10 Jul 2014 21:39:55 +0000 (UTC) Received: from mail-lb0-x229.google.com (mail-lb0-x229.google.com [IPv6:2a00:1450:4010:c04::229]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id D9219274D for ; Thu, 10 Jul 2014 21:39:54 +0000 (UTC) Received: by mail-lb0-f169.google.com with SMTP id l4so172155lbv.14 for ; Thu, 10 Jul 2014 14:39:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=clockworksquid.com; s=google; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc:content-type; bh=t3cY8+/jdaveR/H2Z+0wCz6zaCeZM0/IsU9Z52l9SXU=; b=A5eoTQ/ToxlrcZKbcB3J+gdToT1H/hEKGiCWEghoZm/y5Z0zO2dKVVYYT7w8IZjBOs TYOIXQdHF3YqSP1qumJ4Kmm0JmkfcJdrcvE1jsCSXW65rBkh88OZW4u8fHzjcc+djY13 3o8zsRzDg5OifqqsIdF0PLwl/pR/qWRU5cSRo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc:content-type; bh=t3cY8+/jdaveR/H2Z+0wCz6zaCeZM0/IsU9Z52l9SXU=; b=bw34Qhk7gztQlMLhLMRJ2eGXpT97OJY1yer0WvORaUenxuhqN2jann8xDxkRvkI/Ty qmHBQSj5/hfWwok9y4zYsZbKmXxWPCfxhj+XexeTQbXyJvxiDFOP+IAUSmQsC9KifwPX pQRY4DRIJNuTKZHB87rjuhq99zpXrVUcDBvG0O7PcWZb9qGg4AQ7RD49I5rZTkWqGTa+ KfxVW94bDZEaxk37NSrvEf5PTRYKc1AQmD2OHmNG8kKkm+kjl2E42Eo6p94R3VhZMBBt RMbor/P15T/Va1mkWj1a7wYKnEzebLrrmGqCg5sWoB+B4Y79GXUovbTvTeRgf89sN7U/ pMfg== X-Gm-Message-State: ALoCoQkrHk80b/r7qEyHroXRVIWczCyGRWSsPjUNXERKLCkrGYHbtob1epTXCQUHeVulCvAqgviJ X-Received: by 10.112.161.71 with SMTP id xq7mr293173lbb.57.1405028392609; Thu, 10 Jul 2014 14:39:52 -0700 (PDT) MIME-Version: 1.0 Sender: juli@clockworksquid.com Received: by 10.152.207.133 with HTTP; Thu, 10 Jul 2014 14:39:31 -0700 (PDT) In-Reply-To: References: <201407101215.s6ACF3v1055260@svn.freebsd.org> <20140710152353.GF1812@ptrcrt.ch> <20140710154213.GG1812@ptrcrt.ch> <20140710155342.GB93051@ivaldir.etoilebsd.net> <20140710160506.GH1812@ptrcrt.ch> From: Juli Mallett Date: Thu, 10 Jul 2014 14:39:31 -0700 X-Google-Sender-Auth: cuWiSI07S3hMHFiAxOHTfMQge1s Message-ID: Subject: Re: svn commit: r268491 - head/usr.bin/users To: Ed Schouten Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.18 Cc: svn-src-head@freebsd.org, Baptiste Daroussin , src-committers@freebsd.org, svn-src-all@freebsd.org, Pietro Cerutti X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Jul 2014 21:39:55 -0000 On Thu, Jul 10, 2014 at 9:11 AM, Ed Schouten wrote: > On 10 July 2014 18:05, Pietro Cerutti wrote: > > I reply to this one, since I'm not on src-all. > > > > - for consistency, I'd s|std::set|set| > > - return (0) is not needed in c++ > > Good catch. Fixed! > If we're going to have more C++ in base we may want to pause and think about style(9) for C++ briefly. I'm not sure implicit return is something that fits the rest of the FreeBSD style, for instance.