From owner-cvs-ports@FreeBSD.ORG Tue Jun 1 02:09:43 2010 Return-Path: Delivered-To: cvs-ports@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 293E0106566C for ; Tue, 1 Jun 2010 02:09:43 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from mail2.fluidhosting.com (mx21.fluidhosting.com [204.14.89.4]) by mx1.freebsd.org (Postfix) with ESMTP id A8B538FC14 for ; Tue, 1 Jun 2010 02:09:42 +0000 (UTC) Received: (qmail 20174 invoked by uid 399); 1 Jun 2010 02:09:40 -0000 Received: from localhost (HELO foreign.dougb.net) (dougb@dougbarton.us@127.0.0.1) by localhost with ESMTPAM; 1 Jun 2010 02:09:40 -0000 X-Originating-IP: 127.0.0.1 X-Sender: dougb@dougbarton.us Message-ID: <4C046BE2.7010209@FreeBSD.org> Date: Mon, 31 May 2010 19:09:38 -0700 From: Doug Barton Organization: http://SupersetSolutions.com/ User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.9.1.9) Gecko/20100330 Thunderbird/3.0.4 MIME-Version: 1.0 To: Norikatsu Shigemura References: <201005300441.o4U4foHS067210@repoman.freebsd.org> <4C02D5E9.4000400@FreeBSD.org> <20100601014948.771f2b98.nork@FreeBSD.org> In-Reply-To: <20100601014948.771f2b98.nork@FreeBSD.org> X-Enigmail-Version: 1.0.1 OpenPGP: id=1A1ABC84 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/databases Makefile ports/databases/flare Makefile distinfo pkg-descr pkg-plist ports/databases/flare/files flared.sh.in flarei.sh.in patch-etc-flared.conf patch-etc-flarei.conf patch-flared-flared.cc patch-flared-ini_option.cc ... X-BeenThere: cvs-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Jun 2010 02:09:43 -0000 On 05/31/10 09:49, Norikatsu Shigemura wrote: > Hi dougb. > > On Sun, 30 May 2010 14:17:29 -0700 > Doug Barton wrote: >> There are numerous problems with the rc.d scripts for this port. The >> single biggest problem is that no new scripts should be added with the >> .sh suffix, as it's never installed that way anymore. The attached patch >> fixes the other problems, but I haven't changed the file names in order >> to make the changes obvious. > > Thanks for your review& suggestion. I forgot ports handbook style (*1). > > (*1) http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/rc-scripts.html > > I missed some copy&paste from ports/net/cvsync/files/cvsyncd.in, > e.g. I wont use *_conffile, it's toooo error! > I committed, thank you. Looks good, thanks for getting to this so fast. :) Doug -- ... and that's just a little bit of history repeating. -- Propellerheads Improve the effectiveness of your Internet presence with a domain name makeover! http://SupersetSolutions.com/