From owner-svn-src-user@FreeBSD.ORG Sun May 15 16:43:51 2011 Return-Path: Delivered-To: svn-src-user@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2DCE2106566B; Sun, 15 May 2011 16:43:51 +0000 (UTC) (envelope-from mdf356@gmail.com) Received: from mail-wy0-f182.google.com (mail-wy0-f182.google.com [74.125.82.182]) by mx1.freebsd.org (Postfix) with ESMTP id 7DA5D8FC13; Sun, 15 May 2011 16:43:50 +0000 (UTC) Received: by wyf23 with SMTP id 23so3905429wyf.13 for ; Sun, 15 May 2011 09:43:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=C1C6OXBXP6YsLM3JtfsTiRR1w4W01GVPR0LrksOsGds=; b=gf0oOKF0yW21lOkuPCdUCf41crVF6zXZv6NeCMcscDdkxXk6XXH+8RpqD6BEqFfq+3 cF+k2I+wCs+Yf0NbCGqCext93lNGa3TkgLuwUTLOTFFIylaIknidHw5SqzEp/y5XZ+pl Yk0cn32d1oAal+7eaQg215ayJ3s1rin13YEMU= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=kWsBssihSTDFOeZlYjH1P+JhrN2FfwD8hy4s/WdKhOJVNtwmb/pIY4K1VXtH4Ce5Ef kL82pzixyao9HELMJy2ysG9DTa7+A0dDqw4ed5BMFalQOcmqQAgfiQlPU2BfiCN/EH0w Dra6B2e+6FN3hZQvaqR1A2pvjhsQxQ+qfA17A= MIME-Version: 1.0 Received: by 10.216.79.10 with SMTP id h10mr57389wee.20.1305476387675; Sun, 15 May 2011 09:19:47 -0700 (PDT) Received: by 10.216.153.104 with HTTP; Sun, 15 May 2011 09:19:47 -0700 (PDT) In-Reply-To: <4DCFFAFF.7020403@FreeBSD.org> References: <201105151432.p4FEWtTw042031@svn.freebsd.org> <20110515150759.GI111@hoeg.nl> <4DCFFAFF.7020403@FreeBSD.org> Date: Sun, 15 May 2011 09:19:47 -0700 Message-ID: From: Matthew Fleming To: Andriy Gapon Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: Ed Schouten , "src-committers@freebsd.org" , "svn-src-user@freebsd.org" Subject: Re: svn commit: r221962 - in user/avg/xcpu/sys: kern sys X-BeenThere: svn-src-user@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the experimental " user" src tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 15 May 2011 16:43:51 -0000 On Sunday, May 15, 2011, Andriy Gapon wrote: > on 15/05/2011 18:07 Ed Schouten said the following: >> Hey Andriy, >> >> * Andriy Gapon , 20110515 16:32: >>> - =A0 =A0if (IS_PANIC_THREAD()) >>> + =A0 =A0if (THREAD_PANICED()) >> >> Shouldn't this be called THREAD_PANICKED(), with the k, instead? >> > > Yes, it should be. =A0Thank you. Shouldn't it be TD_IS_PANIC[K]ED to match many of the other checks like TD_IS_IDLETHREAD? Or perhaps to avoid a spelling change, TD_IS_INPANIC? Thanks, matthew