From owner-svn-src-all@FreeBSD.ORG Fri Jul 11 17:51:34 2014 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 3DF44CC1; Fri, 11 Jul 2014 17:51:34 +0000 (UTC) Received: from mail-qa0-x231.google.com (mail-qa0-x231.google.com [IPv6:2607:f8b0:400d:c00::231]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id BEAD9249B; Fri, 11 Jul 2014 17:51:33 +0000 (UTC) Received: by mail-qa0-f49.google.com with SMTP id dc16so1135161qab.22 for ; Fri, 11 Jul 2014 10:51:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=d6SsYAwUrIyOf36XjjuOdViEq9qXQZ+BJcJnMj063yg=; b=km2qtd8L2Ev1qd5tLTeaxS/8H2Arp+ff4m/ny51mDYC0/hDEYmVclrVWczJWt8HaXn orhpoMGp8MLjd5U7lOzsT1IOxFPqvZDgFnqSMWjqHG/R5PJnwhmyfrGrKvaq4GF2LJRL Hq7+dxW9hFzqdyKUnb/eTpDkhawCE3LQv/9nvDk33I33WDedpe5jKw9r6NU5CQaDIMT5 mhivuFym+F7vFzT13g0q7ykb0aVZxmCPfdek6QxyDlsj36UL4ISP7pTo8gVTro/AivhR IqbUnvI84bsPuxcIihcOlU86M10CEJrRw/CepfVaOnHL8qXIcKhwQ4keLQ+z35/N0Q/L fd3Q== MIME-Version: 1.0 X-Received: by 10.140.34.201 with SMTP id l67mr443814qgl.61.1405101092488; Fri, 11 Jul 2014 10:51:32 -0700 (PDT) Sender: florent.thoumie@gmail.com Received: by 10.140.41.40 with HTTP; Fri, 11 Jul 2014 10:51:32 -0700 (PDT) In-Reply-To: <201407111238.23391.jhb@freebsd.org> References: <201407111616.s6BGGQFW060195@svn.freebsd.org> <201407111238.23391.jhb@freebsd.org> Date: Fri, 11 Jul 2014 10:51:32 -0700 X-Google-Sender-Auth: HxdwKEPU1RWJYwilZhmaHp1GsW8 Message-ID: Subject: Re: Phabric IDs / URLs in commits From: Florent Thoumie To: John Baldwin Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.18 Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Jul 2014 17:51:34 -0000 I don't know the ins and outs of arcanist but at Facebook we use 'arc amend' to update the local commit message with whatever is in phabricator. This includes the name of the reviewer. Florent On Fri, Jul 11, 2014 at 9:38 AM, John Baldwin wrote: > On Friday, July 11, 2014 12:16:26 pm John Baldwin wrote: > > Author: jhb > > Date: Fri Jul 11 16:16:26 2014 > > New Revision: 268531 > > URL: http://svnweb.freebsd.org/changeset/base/268531 > > > > Log: > > Fix some edge cases with rewinddir(): > > - In the unionfs case, opendir() and fdopendir() read the directory's > full > > contents and cache it. This cache is not refreshed when rewinddir() > is > > called, so rewinddir() will not notice updates to a directory. Fix > this > > by splitting the code to fetch a directory's contents out of > > __opendir_common() into a new _filldir() function and call this from > > rewinddir() when operating on a unionfs directory. > > - If rewinddir() is called on a directory opened with fdopendir() > before > > any directory entries are fetched, rewinddir() will not adjust the > seek > > location of the backing file descriptor. If the file descriptor > passed > > to fdopendir() had a non-zero offset, the rewinddir() will not > rewind to > > the beginning. Fix this by always seeking back to 0 in rewinddir(). > > This means the dd_rewind hack can also be removed. > > > > While here, add missing locking to rewinddir(). > > > > CR: https://phabric.freebsd.org/D312 > > Reviewed by: jilles > > MFC after: 1 week > > Just picking my own commit here as a sample case. > > I think we should be annotating commits with phabricator code reviews in > some > way when a change has gone through that review. It is very useful to get > back > to the review details from the commit log message in svnweb, etc. > > I can see a number of different ways to do this, but I do think it would be > nice to pick a consistent way to do it. > > Things to consider: > > 1) The tag ("CR:" is what I used above). I don't care, just pick one. I > chose CR since Warner used it previously. Whatever we decide, we should > add it to the template. > > 2) ID vs full URL. For PRs we just list the bug ID and not the full URL > (same for Coverity). I would be fine with that so long as someone hacks > up svnweb to convert the IDs into links (the way it handles PR bug > numbers). OTOH, if you use the full URL you get that for free in > svnweb, > and you also get it in mail clients, etc. It helps that the URL isn't > but > so long. > > This is more of a pie-in-the-sky, but it would be _really_ nice if arcanist > were hacked up to support our local commit template and would auto populate > the 'Reviewed by' and 'CR' (or whatever it ends up being called) fields so > one > could use 'arc commit'. > > So what do folks prefer for 1) and 2)? > > -- > John Baldwin > _______________________________________________ > svn-src-all@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/svn-src-all > To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org" > -- Florent