From owner-freebsd-ppc@FreeBSD.ORG Sun Nov 2 17:23:47 2008 Return-Path: Delivered-To: freebsd-ppc@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id BF7EB106567D for ; Sun, 2 Nov 2008 17:23:47 +0000 (UTC) (envelope-from nwhitehorn@freebsd.org) Received: from mail.icecube.wisc.edu (trout.icecube.wisc.edu [128.104.255.119]) by mx1.freebsd.org (Postfix) with ESMTP id 980E98FC0C for ; Sun, 2 Nov 2008 17:23:47 +0000 (UTC) (envelope-from nwhitehorn@freebsd.org) Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.icecube.wisc.edu (Postfix) with ESMTP id A577B58248; Sun, 2 Nov 2008 11:23:46 -0600 (CST) X-Virus-Scanned: amavisd-new at icecube.wisc.edu Received: from mail.icecube.wisc.edu ([127.0.0.1]) by localhost (trout.icecube.wisc.edu [127.0.0.1]) (amavisd-new, port 10030) with ESMTP id PJJV5aqZMRvb; Sun, 2 Nov 2008 11:23:46 -0600 (CST) Received: from wanderer.tachypleus.net (dyn-29-126.uwnet.wisc.edu [72.33.29.126]) by mail.icecube.wisc.edu (Postfix) with ESMTP id 81AED58244; Sun, 2 Nov 2008 11:23:46 -0600 (CST) Message-ID: <490DE209.4020109@freebsd.org> Date: Sun, 02 Nov 2008 11:23:21 -0600 From: Nathan Whitehorn User-Agent: Thunderbird 2.0.0.17 (X11/20081002) MIME-Version: 1.0 To: Ed Schouten References: <20081102171754.GS1165@hoeg.nl> In-Reply-To: <20081102171754.GS1165@hoeg.nl> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: freebsd-ppc@FreeBSD.org Subject: Re: ADB mouse fixup X-BeenThere: freebsd-ppc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting FreeBSD to the PowerPC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 02 Nov 2008 17:23:47 -0000 Ed Schouten wrote: > Hello all, > > After getting Xorg working on my Powerbook 12", I noticed the mouse > driver did something strange w.r.t. mouse buttons. After adding printf's > to the source code, I noticed it generated button 2 clicks each time I > just touched the pad. > > It turns out there is this a piece of code in the ADB mouse driver that > converts events of buttons that exceed the amount of buttons of the > device to button events of the last available button. Disabling this > code makes the mouse driver work properly. > > Any comments on the attached patch before I commit it to SVN? Thanks! > > That is really strange. As it happens, the code currently there for high buttons is to handle an external ALPS Glidepoint touchpad I have with 3 buttons that gives button events on buttons 1,2, and 4. The rest of my hardware behaves correctly, and the ALPS device reports itself as a mouse, not a trackpad, so I think the patch is fine. Crazy Apple hardware... -Nathan