From owner-svn-src-all@FreeBSD.ORG Sat Jul 12 12:48:22 2014 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 0C068748; Sat, 12 Jul 2014 12:48:22 +0000 (UTC) Received: from mho-01-ewr.mailhop.org (mho-03-ewr.mailhop.org [204.13.248.66]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id CF9AE2FB4; Sat, 12 Jul 2014 12:48:21 +0000 (UTC) Received: from c-50-155-136-3.hsd1.co.comcast.net ([50.155.136.3] helo=ilsoft.org) by mho-01-ewr.mailhop.org with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.72) (envelope-from ) id 1X5wix-0005o3-A1; Sat, 12 Jul 2014 12:48:19 +0000 Received: from [172.22.42.240] (revolution.hippie.lan [172.22.42.240]) by ilsoft.org (8.14.9/8.14.9) with ESMTP id s6CCmIGC002827; Sat, 12 Jul 2014 06:48:18 -0600 (MDT) (envelope-from ian@FreeBSD.org) X-Mail-Handler: Dyn Standard SMTP by Dyn X-Originating-IP: 50.155.136.3 X-Report-Abuse-To: abuse@dyndns.com (see http://www.dyndns.com/services/sendlabs/outbound_abuse.html for abuse reporting information) X-MHO-User: U2FsdGVkX1/T7IKhRagbPRT6/4S5Sueg X-Authentication-Warning: paranoia.hippie.lan: Host revolution.hippie.lan [172.22.42.240] claimed to be [172.22.42.240] Subject: Re: svn commit: r268543 - in head/sys: dev/drm2 dev/drm2/i915 dev/drm2/radeon dev/etherswitch/arswitch dev/etherswitch/rtl8366 dev/iicbus sys From: Ian Lepore To: Rui Paulo In-Reply-To: References: <201407120104.s6C14BYo080629@svn.freebsd.org> <1405129355.91430.4.camel@revolution.hippie.lan> Content-Type: text/plain; charset="us-ascii" Date: Sat, 12 Jul 2014 06:48:17 -0600 Message-ID: <1405169297.91430.10.camel@revolution.hippie.lan> Mime-Version: 1.0 X-Mailer: Evolution 2.32.1 FreeBSD GNOME Team Port Content-Transfer-Encoding: 7bit Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 12 Jul 2014 12:48:22 -0000 On Fri, 2014-07-11 at 18:48 -0700, Rui Paulo wrote: > On Jul 11, 2014, at 18:42, Ian Lepore wrote: > > > On Sat, 2014-07-12 at 01:04 +0000, Rui Paulo wrote: > >> Author: rpaulo > >> Date: Sat Jul 12 01:04:10 2014 > >> New Revision: 268543 > >> URL: http://svnweb.freebsd.org/changeset/base/268543 > >> > >> Log: > >> Move iic.h to sys/ so that it's automatically installed in /usr/include/sys. > >> > >> This lets us call iic(4) ioctls without needing the kernel source code > >> and follows the same model of GPIO. > >> > >> MFC after: 3 weeks > > > > It was already available in /usr/include/dev/iicbus, and now it's not > > going to be, potentially breaking out-of-tree stuff. Hrm... in fact > > definitely breaking it, we have references to dev/iicbus/iic.h in our > > apps at $work. > > Hmm. In that case, which one is correct? Should sys/gpio.h exist? > > -- > Rui Paulo > sys/gpio.h feels out of place to me -- it's device stuff, it should live in include/dev/gpio. Moving it now might create the same sort of trouble for out-of-tree code, unless we also put a symlink in the old location. -- Ian