From owner-svn-src-all@FreeBSD.ORG  Sat Jul 12 21:43:25 2014
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id C391C7D9;
 Sat, 12 Jul 2014 21:43:25 +0000 (UTC)
Received: from mx1.stack.nl (relay02.stack.nl [IPv6:2001:610:1108:5010::104])
 (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits))
 (Client CN "mailhost.stack.nl",
 Issuer "CA Cert Signing Authority" (not verified))
 by mx1.freebsd.org (Postfix) with ESMTPS id 854C926B5;
 Sat, 12 Jul 2014 21:43:25 +0000 (UTC)
Received: from snail.stack.nl (snail.stack.nl [IPv6:2001:610:1108:5010::131])
 by mx1.stack.nl (Postfix) with ESMTP id 956E93592E0;
 Sat, 12 Jul 2014 23:43:22 +0200 (CEST)
Received: by snail.stack.nl (Postfix, from userid 1677)
 id 7454128497; Sat, 12 Jul 2014 23:43:22 +0200 (CEST)
Date: Sat, 12 Jul 2014 23:43:22 +0200
From: Jilles Tjoelker <jilles@stack.nl>
To: Dimitry Andric <dim@freebsd.org>
Subject: Re: svn commit: r268491 - head/usr.bin/users
Message-ID: <20140712214322.GA33663@stack.nl>
References: <201407101215.s6ACF3v1055260@svn.freebsd.org>
 <CAJOYFBCQjjN7ep12zivnmFjfeeP1SeoYa963mQbMJr9DD+fUnw@mail.gmail.com>
 <20140710152353.GF1812@ptrcrt.ch>
 <CAJOYFBDZiEpQ5e86+dBhRZobSjdf785bKBwh+3Eywhzn_iJJCQ@mail.gmail.com>
 <7E0B8EDA-7932-454B-BACC-FCA956CD012E@freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <7E0B8EDA-7932-454B-BACC-FCA956CD012E@freebsd.org>
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: svn-src-head@freebsd.org, Ed Schouten <ed@80386.nl>,
 svn-src-all@freebsd.org, src-committers@freebsd.org,
 Pietro Cerutti <gahr@freebsd.org>
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 12 Jul 2014 21:43:25 -0000

On Sat, Jul 12, 2014 at 11:06:33PM +0200, Dimitry Andric wrote:
> On 10 Jul 2014, at 17:29, Ed Schouten <ed@80386.nl> wrote:
> > On 10 July 2014 17:23, Pietro Cerutti <gahr@freebsd.org> wrote:
> >> It's because of the standard library. Examples:

> >> /usr/include/c++/v1/memory:1454:47: error: unused parameter '__a'
> >> [-Werror,-Wunused-parameter]
> >>        static void construct(allocator_type& __a, _Tp* __p)

> >> /usr/include/c++/v1/__functional_base:85:12: error: cast from 'const
> >> volatile char *' to 'wchar_t *' increases required alignment from 1 to 4
> >> [-Werror,-Wcast-align]
> >>    return (_Tp*)&reinterpret_cast<const volatile char&>(__x);

> > Then I would suggest that these specific warnings (-Wunused-parameter)
> > were to be disabled for C++ programs. The actual consumers should not
> > have to lower their WARNS, simply because the standard library is
> > broken.

> IMHO it is not broken at all, but for some reason we compile everything
> with -Wsystem-headers when WARNS=1 or higher. :-)

I think -Wsystem-headers makes sense (at least in C) because we maintain
the system headers as part of FreeBSD and therefore want to fix issues
in them as well.

If the C++ standard library has a lower quality level goal, then it may
be appropriate to disable -Wsystem-headers for C++ so at least the
programs themselves can use high WARNS.

-- 
Jilles Tjoelker