From owner-freebsd-current@freebsd.org Wed Jul 8 09:53:43 2015 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 24E7F996263 for ; Wed, 8 Jul 2015 09:53:43 +0000 (UTC) (envelope-from oliver.pinter@hardenedbsd.org) Received: from mail-wi0-f176.google.com (mail-wi0-f176.google.com [209.85.212.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id BB5F51EA7 for ; Wed, 8 Jul 2015 09:53:42 +0000 (UTC) (envelope-from oliver.pinter@hardenedbsd.org) Received: by wibdq8 with SMTP id dq8so207273272wib.1 for ; Wed, 08 Jul 2015 02:53:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=O0QbtfXDG/Loh8wbR8fOTFzxzQOu+UrzrtB1BDSQvMQ=; b=XtqXIO5YwUVUcBTC35GhzqCyMsjBa2olkRgRxaoJsCKT2aIHushIlwS5+vhXf9zJgW UZefyyvDffeY61K8tSq2hr3wGyfZgxoHQQqo+AShxjZSu+lS92oXJzgqBRtsQVee8/ZR nnZ7xWHazMLzS+omm9nmwqov5Ukf0VJEZMTNPp1xiXLZ9dZ9oLLj6iRvah7rfYlYJtrD 7HmTQMkc5DH5ePd0a/OOq1kJfR3SpHmSMPkPyVqxY+IqgQGN5dieiqaAzA7MBjYoOV3z S3P7u5aCQ/Q7estVp3ISBAPK+IpLokcowdqrhiO8uEhY8fshRvEWpGEWsLbyYnS8L2D4 fihw== X-Gm-Message-State: ALoCoQkwK/SepjE9/JbeHY+Xac0yjTrBIRm07E9Tg3DJiFl9tjDYrtGbb3WjZsndeu95Ce6BdAO+ MIME-Version: 1.0 X-Received: by 10.194.2.161 with SMTP id 1mr17312349wjv.143.1436349219945; Wed, 08 Jul 2015 02:53:39 -0700 (PDT) Received: by 10.194.73.6 with HTTP; Wed, 8 Jul 2015 02:53:39 -0700 (PDT) In-Reply-To: <94BCDA65-5B86-4329-A312-4CB16E847B69@dons.net.au> References: <201507072241.t67MfsX5085860@hergotha.csail.mit.edu> <94BCDA65-5B86-4329-A312-4CB16E847B69@dons.net.au> Date: Wed, 8 Jul 2015 11:53:39 +0200 Message-ID: Subject: Re: gettimeofday((void *)-1, NULL) implicates core dump on recent FreeBSD 11-CURRENT From: Oliver Pinter To: "O'Connor, Daniel" Cc: Garrett Wollman , freebsd-current@freebsd.org Content-Type: text/plain; charset=UTF-8 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Jul 2015 09:53:43 -0000 On 7/8/15, O'Connor, Daniel wrote: > >> On 8 Jul 2015, at 08:11, Garrett Wollman >> wrote: >> Perhaps the test was (erroneously) written to assume that >> gettimeofday() was a system call, and could therefore detect invalid >> pointers and return [EFAULT]. This has not been the case for some >> time. (In HEAD, not since r237434, which is three years ago.) > > In defence of the test, the man page says it can return EFAULT. That's fine, but why changed the behaviour since 2015. May 27.? I have an older FreeBSD/HardenedBSD install, where this test passing. See some previous email in this thread. > > (IMO the man page and test should change..) > > -- > Daniel O'Connor > "The nice thing about standards is that there > are so many of them to choose from." > -- Andrew Tanenbaum > GPG Fingerprint - 5596 B766 97C0 0E94 4347 295E E593 DC20 7B3F CE8C > >