From owner-freebsd-arch@FreeBSD.ORG Mon Feb 28 02:17:34 2005 Return-Path: Delivered-To: freebsd-arch@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6203616A4CE for ; Mon, 28 Feb 2005 02:17:34 +0000 (GMT) Received: from smtp3.server.rpi.edu (smtp3.server.rpi.edu [128.113.2.3]) by mx1.FreeBSD.org (Postfix) with ESMTP id E206243D2F for ; Mon, 28 Feb 2005 02:17:33 +0000 (GMT) (envelope-from drosih@rpi.edu) Received: from [128.113.24.47] (gilead.netel.rpi.edu [128.113.24.47]) by smtp3.server.rpi.edu (8.13.0/8.13.0) with ESMTP id j1S2HWJf018852; Sun, 27 Feb 2005 21:17:32 -0500 Mime-Version: 1.0 Message-Id: In-Reply-To: <421DAD8F.6000704@portaone.com> References: <200410020349.i923nG8v021675@northstar.hetzel.org> <20041002052856.GE17792@nexus.dglawrence.com> <20041002233542.GL714@nexus.dglawrence.com> <421DAD8F.6000704@portaone.com> Date: Sun, 27 Feb 2005 21:17:31 -0500 To: Maxim Sobolev From: Garance A Drosihn Content-Type: text/plain; charset="us-ascii" ; format="flowed" X-CanItPRO-Stream: default X-RPI-SA-Score: undef - spam-scanning disabled X-Scanned-By: CanIt (www . canit . ca) cc: freebsd-arch@freebsd.org Subject: Re: Bug in #! processing - One More Time X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 28 Feb 2005 02:17:34 -0000 At 12:33 PM +0200 2/24/05, Maxim Sobolev wrote: >Garance A Drosihn wrote: >> >>As I see it, we have the following choices to fix this: >> >>1) MFC the January 31st change to kern/imgact_shell.c to 5.3-stable, >> as it is. This means we haven't fixed the problem that people >> complained about in 2002 and again in 2004. And I still think >> it is "not appropriate" for the execve() system to be deciding >> what '#' means on that line. The biggest advantage is that this >> means 5.4-release will behave exactly the same as 3.5 through >> 5.3-release have behaved. We have the code-freeze coming up on Wednesday. It turns out the Jan 31st change had some bugs in it, and afaik we are still coming up with a better version of that for *current*, never mind -stable. At this point I think we should revert change 1.26.4.1 in -stable, such that 5.4-release will behave the same way as all previous releases. Which is to say, it will continue to look for '#' on the shebang line, and ignore everything after one is found. I have a patch ready to do this, assuming people aren't too upset at the idea. I just don't feel comfortable trying to rush through multiple changes for this issue at the last minute. -- Garance Alistair Drosehn = gad@gilead.netel.rpi.edu Senior Systems Programmer or gad@freebsd.org Rensselaer Polytechnic Institute or drosih@rpi.edu