From owner-svn-src-all@FreeBSD.ORG Mon Jul 14 18:47:31 2014 Return-Path: Delivered-To: svn-src-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 9446AE81; Mon, 14 Jul 2014 18:47:31 +0000 (UTC) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id F0B3C266C; Mon, 14 Jul 2014 18:47:30 +0000 (UTC) Received: from tom.home (kib@localhost [127.0.0.1]) by kib.kiev.ua (8.14.9/8.14.9) with ESMTP id s6EIlPZj032289 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 14 Jul 2014 21:47:26 +0300 (EEST) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.8.3 kib.kiev.ua s6EIlPZj032289 Received: (from kostik@localhost) by tom.home (8.14.9/8.14.9/Submit) id s6EIlPne032288; Mon, 14 Jul 2014 21:47:25 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Mon, 14 Jul 2014 21:47:25 +0300 From: Konstantin Belousov To: Nathan Whitehorn Subject: Re: svn commit: r268624 - head/sys/dev/vt/hw/efifb Message-ID: <20140714184725.GL93733@kib.kiev.ua> References: <201407141742.s6EHgMNt094168@svn.freebsd.org> <20140714175345.GK93733@kib.kiev.ua> <53C424B7.7070403@freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="qt/8o3zVjmkHzDiC" Content-Disposition: inline In-Reply-To: <53C424B7.7070403@freebsd.org> User-Agent: Mutt/1.5.23 (2014-03-12) X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.0 X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on tom.home Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Jul 2014 18:47:31 -0000 --qt/8o3zVjmkHzDiC Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jul 14, 2014 at 11:43:03AM -0700, Nathan Whitehorn wrote: >=20 > On 07/14/14 10:53, Konstantin Belousov wrote: > > On Mon, Jul 14, 2014 at 05:42:22PM +0000, Nathan Whitehorn wrote: > >> + info->fb_vbase =3D (intptr_t)pmap_mapdev_attr(info->fb_pbase, > >> + info->fb_size, VM_MEMATTR_WRITE_COMBINING); > >> +} > >> + > > Could you use pmap_change_attr() ? This would save some KVA. >=20 > Does that work with the direct map? I'm pretty hesitant to muck with the= =20 > direct map region this way... Yes, it works on direct map. Note that Intel explicitely states that the behaviour is undefined if the same physical page is mapped with differrent caching attributes. At least some revisions of Pentium IV hang in this situation. We keep direct map mapping attributes consistent with other mappings. --qt/8o3zVjmkHzDiC Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJTxCW9AAoJEJDCuSvBvK1B5i8P/0Mmj5xRf9mpoIIJ2DVNWcff WycF2aPOtfwqFkWsnGphyAHedRdXTY2mPXfrTGdaSejKhGJ/wVZ+MCAehqKlk9RP voUuoJO6EQcfzkl7QmipJFJuIhg5Pj8oOxYEXFrEG16yfDKOlI1NMGeks5ryQnT2 B4BJi15PG4F0sYFSARDaTqkmY0RYeN/2gCxge5mutfLkfk2sDwiQC2Ds8R94zW8p ToYJ1P4MROzw8bE1AMZuM0g/wVMql55jL/TSDd8k50HfRQTQbTK1hvENocFL4dsK FY9tLNjGhMBjk0tAsgqd0Pwy3ded0MNlJ2cfDCshf0fP3PBzuNTNfIuo4d+o01ZH jwp4q16vPyJLFH6YnsWBI+KvFttrzOvFqDe7h+fDuFY8woZ6IUvcuqEQ/oivy3OO Ot+3mqYKIAZoFlg/4PKHhco2lfeKri8ggtESJhbhjwvSUdw+u1MzeeLrPmomVUg+ jeUdSnVuFvvVx2z0qYrZn6PVL2thEqOJ5nyt8W5ziIwxvtA/0AHpvoYI8DKlzT7V EHI6FTHG1Ym/KKybbroZ8XXGbATjDXpdDDez8o7bya8iNoQcIofdIutDp9aoKA51 HyaC6HQlMn3Oud1/jQJRGDzR3YJz25qBONit8mnK1ER6BS8UaG1dgdDxgbEAWiH8 JKuWZQOVsajGoTdz7Oau =vSHF -----END PGP SIGNATURE----- --qt/8o3zVjmkHzDiC--