From owner-svn-src-all@FreeBSD.ORG Tue Jul 15 15:30:18 2014 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 37983613; Tue, 15 Jul 2014 15:30:18 +0000 (UTC) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 95043225E; Tue, 15 Jul 2014 15:30:17 +0000 (UTC) Received: from tom.home (kib@localhost [127.0.0.1]) by kib.kiev.ua (8.14.9/8.14.9) with ESMTP id s6FFUBtm069581 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 15 Jul 2014 18:30:11 +0300 (EEST) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.8.3 kib.kiev.ua s6FFUBtm069581 Received: (from kostik@localhost) by tom.home (8.14.9/8.14.9/Submit) id s6FFUBk8069580; Tue, 15 Jul 2014 18:30:11 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Tue, 15 Jul 2014 18:30:11 +0300 From: Konstantin Belousov To: Ian Lepore Subject: Re: svn commit: r268660 - head/sys/amd64/amd64 Message-ID: <20140715153011.GR93733@kib.kiev.ua> References: <201407150930.s6F9Uhgi052394@svn.freebsd.org> <1405432340.1312.26.camel@revolution.hippie.lan> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="yckM7CAr5H2WMv0u" Content-Disposition: inline In-Reply-To: <1405432340.1312.26.camel@revolution.hippie.lan> User-Agent: Mutt/1.5.23 (2014-03-12) X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.0 X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on tom.home Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 Jul 2014 15:30:18 -0000 --yckM7CAr5H2WMv0u Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jul 15, 2014 at 07:52:20AM -0600, Ian Lepore wrote: > > bcopy(a_cp, b_cp, cnt); > > + if (__predict_false(pinned)) { > > + sched_unpin(); > > + mtx_unlock(&cpage_lock); > > + pinned =3D FALSE; >=20 > Should this pinned =3D FALSE be done under the cpage_lock to avoid a race? What race ? Could you describe it in more details ? Note that pinned is local variable. --yckM7CAr5H2WMv0u Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJTxUkCAAoJEJDCuSvBvK1Bvq0P/19GAobGUQmVkQlBd6knD201 lPIcHH+TOtpUYePTndxqIwVO+o+oK/R8S9g+1WdFZh3g6ptcNCJGjKB8VNJvHkny 0D61Lkvg/5OyQLWTBgOO2nZu5sIWcjRn3Bsg+lA+2BpCrTsRbvt3w1sXWYuNBRcg RqLB2HaNcC6PvHU3nFec5DkSvp3yg6wt3B2xTiOpA6tYsni8u80BSBAngSyidD0H P++vmQmQcwYduvkM/DVeW4ovoImOLu7dqVxfHGs7mDZF1SoZOcFJXwQhQMN1j4ho 0gYeMduyfxVX6P9rSm90Fn2CrLE6YtwY/wETsrjlK8VFOY4JRe1HC6DAJg2XlDsf iKiy9a+wBJOMLB92R0y+ABVfDJBaXeFqYvHbov66HTNC96Jg9KfzKF/bxgF+Qb/q 5hpv+Yk5u5Q6Hw+WycekbRte9yXQDiFXSTZqvoLuoD5g7XY2W0CGIB/eYynUfhGc aIOEiWq8nfWij09Snic9kV4eCNR7LtMYNMKPknnlN2KE6+vBzbGKjANv55aP/WJY pvDLaWF0KAfqn/M61wK869oifpEGIYH6/YQ+kuLBKNhcit3b+/DN7pY/WYQou1yy h1uExTgqkdG9jkjE1pvOD7ejXVEsUOLQg5wwu5QmeMgVImgYuBUH60RZECFNAYKM EoESPnA/KwXZ6c2On+AL =KA00 -----END PGP SIGNATURE----- --yckM7CAr5H2WMv0u--