From owner-freebsd-current@FreeBSD.ORG Thu May 10 20:31:41 2012 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id A5BB9106566C; Thu, 10 May 2012 20:31:41 +0000 (UTC) (envelope-from pluknet@gmail.com) Received: from mail-gg0-f182.google.com (mail-gg0-f182.google.com [209.85.161.182]) by mx1.freebsd.org (Postfix) with ESMTP id 22DEA8FC14; Thu, 10 May 2012 20:31:40 +0000 (UTC) Received: by ggnm2 with SMTP id m2so1629910ggn.13 for ; Thu, 10 May 2012 13:31:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=2kBbgcNjpvAoPOcqPzGYeaWvvL3ERlzhXYq00bIXDfw=; b=gTqZasi3P8l3f0383QBeUdry2UoODieKdSSGnoXGwy9i3QZlAMNt+AgiilPsxg6wLW 7kG8y+bZSEVqjIt79eR8WceKvUgWF/RyjrjHWXPt4/DPeRnGyC7DCJPVDVQp9oIjgldn vDBrN7KOYZ9ErHW3OnW7lgGprI8Bz1XFUyEQ8IciAhEANAxEELOng0bEYGo19/lPv4DP Vg78SmbZxi2rPD8qXpuYnzxEYe4nbh7V9AM3PQqCt50zoM5qKk4lNp49/FaD7zzWX6+F dTd2i05jaRa25SLh4K52oe26/hUo6wZnysMaS+1ChE8KMTn+H/mgb+j4Sb3L6bIe81cG lBiQ== MIME-Version: 1.0 Received: by 10.50.186.162 with SMTP id fl2mr67429igc.56.1336681900154; Thu, 10 May 2012 13:31:40 -0700 (PDT) Sender: pluknet@gmail.com Received: by 10.64.8.170 with HTTP; Thu, 10 May 2012 13:31:40 -0700 (PDT) In-Reply-To: <20120507201153.GA19942@dft-labs.eu> References: <4FA6F324.4080107@FreeBSD.org> <4FA82269.6080406@FreeBSD.org> <20120507201153.GA19942@dft-labs.eu> Date: Fri, 11 May 2012 00:31:40 +0400 X-Google-Sender-Auth: Uq2Rf_fMwkDh3HWjOXb5KhMDmSE Message-ID: From: Sergey Kandaurov To: Mateusz Guzik Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: Peter Holm , mckusick@freebsd.org, Doug Barton , freebsd-current Subject: Re: panic, seems related to r234386 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 May 2012 20:31:41 -0000 On 8 May 2012 00:11, Mateusz Guzik wrote: > On Mon, May 07, 2012 at 12:28:41PM -0700, Doug Barton wrote: >> On 05/06/2012 15:19, Sergey Kandaurov wrote: >> > On 7 May 2012 01:54, Doug Barton wrote: >> >> I got this with today's current, previous (working) kernel is r232719= . >> >> >> >> panic: _mtx_lock_sleep: recursed on non-recursive mutex struct mount = mtx >> >> @ /frontier/svn/head/sys/kern/vfs_subr.c:4595 >> >> ... >> >> > Please try this patch. >> > >> > Index: fs/ext2fs/ext2_vfsops.c >> > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >> > --- fs/ext2fs/ext2_vfsops.c =A0 =A0 (revision 235108) >> > +++ fs/ext2fs/ext2_vfsops.c =A0 =A0 (working copy) >> > @@ -830,7 +830,6 @@ >> > =A0 =A0 =A0 =A0 /* >> > =A0 =A0 =A0 =A0 =A0* Write back each (modified) inode. >> > =A0 =A0 =A0 =A0 =A0*/ >> > - =A0 =A0 =A0 MNT_ILOCK(mp); >> > =A0loop: >> > =A0 =A0 =A0 =A0 MNT_VNODE_FOREACH_ALL(vp, mp, mvp) { >> > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 if (vp->v_type =3D=3D VNON) { >> > >> >> Didn't help, sorry. I put 234385 through some pretty heavy load >> yesterday, and everything was fine. As soon as I move up to 234386, the >> panic triggered again. So I cleaned everything up, applied your patch, >> built a kernel from scratch, and rebooted. It was Ok for a few seconds >> after boot, then panic'ed again, I think in a different place, but I'm >> not sure because subsequent attempts to fsck the file systems caused new >> panics which overwrote the old ones before they could be saved. >> > > Another MNT_ILOCK was hiding few lines below, try this patch: > > http://student.agh.edu.pl/~mjguzik/patches/ext2fs-ilock.patch > > I've tested this a bit and I believe this fixes your problem. I just committed your fix in r235241 since it seems to have no relation to the problem reported by Peter Holm. --=20 wbr, pluknet