From owner-svn-ports-all@FreeBSD.ORG Mon Mar 2 07:34:43 2015 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 8CA29CD; Mon, 2 Mar 2015 07:34:43 +0000 (UTC) Received: from mail-yh0-x231.google.com (mail-yh0-x231.google.com [IPv6:2607:f8b0:4002:c01::231]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 3FCC19DA; Mon, 2 Mar 2015 07:34:43 +0000 (UTC) Received: by yhab6 with SMTP id b6so13754145yha.6; Sun, 01 Mar 2015 23:34:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=FiLo9k0/jyTmVipAzenmhdo8F6Q6wqzVW0dWHcBUKVE=; b=JOYiGTL/FXs7vpW+Oq4jyiJssEgPtue7sGlMgSyTFak42BDf2U3DUUfk7x70TmO2k7 ikaihHD0LHofB/uxlXdskoVaBrevXj6f+ucb7VsOYlvDHvVFuZxCxPw7QRmtiUCRzVGD csINjgopdQrwdeKF3oaVGsQWNI6CqpRz+0/0rl5fTXDR0BWqXRHzXop1oqvuKFPvmzl9 r4Xgj6NJATvCK2lTdK/216lDWvx9rmRzScpT9heAcjj9IbHDvglhD36g5zITUOJtbj0A ljiz6FKCn0ENCum1uhuq2uAzCl6CmLJl9CjL4PgCCnrddmIpYUJHPhE9D8sbmfDB1mXf WKWg== MIME-Version: 1.0 X-Received: by 10.236.17.163 with SMTP id j23mr25321786yhj.138.1425281682349; Sun, 01 Mar 2015 23:34:42 -0800 (PST) Sender: antoine.brodin.freebsd@gmail.com Received: by 10.170.142.198 with HTTP; Sun, 1 Mar 2015 23:34:42 -0800 (PST) In-Reply-To: <54F37212.3010800@marino.st> References: <201503011652.t21GqiLh056130@svn.freebsd.org> <54F3458E.8090401@marino.st> <54F34DC3.8020902@marino.st> <54F35AAD.5010200@marino.st> <54F3678C.90706@marino.st> <54F37212.3010800@marino.st> Date: Mon, 2 Mar 2015 08:34:42 +0100 X-Google-Sender-Auth: c0iAce1fxo2eW-RsBPzZWxHiM6A Message-ID: Subject: Re: svn commit: r380211 - head/security/libgpg-error From: Antoine Brodin To: John Marino Content-Type: text/plain; charset=UTF-8 Cc: "svn-ports-head@freebsd.org" , "svn-ports-all@freebsd.org" , "ports-committers@freebsd.org" X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Mar 2015 07:34:43 -0000 On Sun, Mar 1, 2015 at 9:09 PM, John Marino wrote: > On 3/1/2015 21:05, Antoine Brodin wrote: >> On Sun, Mar 1, 2015 at 8:25 PM, John Marino wrote: >>> On 3/1/2015 19:46, Antoine Brodin wrote: >>>> Can you try using cpp5 -P instead of cpp5? >>>> See http://www.gnu.org/software/gcc/gcc-5/porting_to.html >>>> >>> >>> It works. If I just add "CPP= cpp -P" to the stock port makefile, then >>> it builds fine. I check "cpp -P" on FreeBSD 10, it seems clang cpp just >>> ignores the -P even though it's not a listed option. >>> >>> I guess if we want to use this, the fix would be something like >>> "CPP+= -P" >>> >>> Would all the FreeBSD releases accept "CPP+= -P" ? >> >> I tested the src/Makefile.in part of >> https://build.opensuse.org/source/openSUSE:Factory/libgpg-error/libgpg-error-1.18-gcc5.patch >> on FreeBSD 8.4 / 9.3 / 10.1 / head / head with clang 3.6 and it >> worked. > > Nice to know. What is the rationale for patching the makefiles if > defining CPP in the environment has the same result? > > Just curious because it seems that "CPP+= -P" saves three patches and > I'd think that would be desired. A patch can be submitted upstream (it's not fixed in libgpg-error git and no one opened a bug about it yet) Cheers, Antoine