From owner-svn-src-all@FreeBSD.ORG Wed Jul 16 12:23:01 2014 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 9CFA15CC; Wed, 16 Jul 2014 12:23:01 +0000 (UTC) Received: from mail-we0-x22b.google.com (mail-we0-x22b.google.com [IPv6:2a00:1450:400c:c03::22b]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id DA04021F9; Wed, 16 Jul 2014 12:23:00 +0000 (UTC) Received: by mail-we0-f171.google.com with SMTP id p10so846071wes.16 for ; Wed, 16 Jul 2014 05:22:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=pDE1XinqycR7jXJ63aI1KvT2O6/fgzkoJm+Z6vmwG3o=; b=WzJixLZABGoKUjIaK15VRRu9dHNJdEHGUKIb0LKPqGtYxHFdaTc5RdbR+M6JxSFsCu kSEsRpusXkz6dpw59+3K+drKqOL5MDd0EoAYw6TzUOT2xbHlpu90EmK2a6a9HOun27Rq rubIuniOK7IsuUNaT0AxYbtcqAmPl588i9X5aEie755Ymj9XzxDM/XiGpkl4yjuo2gyi VcuKsN89bStBXODR0Vdzyr1xdnC6a1yfaFURsNlup/RkLRYOCFyYIn7tIewBspaBn2Q5 EmS/3NZhoNhKb6yRCAoLlBggaek8EjpS6eFlOIrRoafIg/InVLHuP6KjrIIdKt5HMzTM nheQ== X-Received: by 10.180.9.202 with SMTP id c10mr13370881wib.13.1405513379027; Wed, 16 Jul 2014 05:22:59 -0700 (PDT) Received: from ivaldir.etoilebsd.net ([2001:41d0:8:db4c::1]) by mx.google.com with ESMTPSA id gd13sm55959265wic.6.2014.07.16.05.22.57 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 16 Jul 2014 05:22:58 -0700 (PDT) Sender: Baptiste Daroussin Date: Wed, 16 Jul 2014 14:22:55 +0200 From: Baptiste Daroussin To: Konstantin Belousov Subject: Re: svn commit: r268750 - head/usr.bin/timeout Message-ID: <20140716122255.GK48710@ivaldir.etoilebsd.net> References: <201407161141.s6GBfSbS034790@svn.freebsd.org> <20140716121900.GX93733@kib.kiev.ua> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="ucfHZChuBC0NsER/" Content-Disposition: inline In-Reply-To: <20140716121900.GX93733@kib.kiev.ua> User-Agent: Mutt/1.5.23 (2014-03-12) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Jul 2014 12:23:01 -0000 --ucfHZChuBC0NsER/ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jul 16, 2014 at 03:19:00PM +0300, Konstantin Belousov wrote: G > On Wed, Jul 16, 2014 at 11:41:28AM +0000, Baptiste Daroussin wrote: > > Author: bapt > > Date: Wed Jul 16 11:41:28 2014 > > New Revision: 268750 > > URL: http://svnweb.freebsd.org/changeset/base/268750 > >=20 > > Log: > > Sort headers > > Constify long options > > Remove useless call to sigemptyset > > properly check errno when waiting for a process status when a SIGCHLD= is received > >=20 > > Modified: > > head/usr.bin/timeout/timeout.c > >=20 > > Modified: head/usr.bin/timeout/timeout.c > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D > > --- head/usr.bin/timeout/timeout.c Wed Jul 16 11:30:04 2014 (r268749) > > +++ head/usr.bin/timeout/timeout.c Wed Jul 16 11:41:28 2014 (r268750) > > @@ -28,20 +28,18 @@ > > #include > > __FBSDID("$FreeBSD$"); > > =20 > > -#include > > -#include > > -#include > > +#include > > +#include > > +#include > > #include > > +#include > > #include > > #include > > #include > > +#include > > +#include > > #include > > #include > > -#include > > -#include > > -#include > > -#include > > -#include > This is not proper sorting. sys/*.h comes first, usermode headers > second. > > =20 > > #define EXIT_TIMEOUT 124 > > =20 > > @@ -188,7 +186,7 @@ main(int argc, char **argv) > > cpid =3D -1; > > pgid =3D -1; > > =20 > > - struct option longopts[] =3D { > > + const struct option longopts[] =3D { > I noted that this should be static const, not just const. static const is just not working here. because of the 2 first entries. >=20 > The curious tendency of late is people committing changes without > getting final confirmation from reviewer. Asking to look at the patch > before commit would avoid repo churn. Maybe because the code is sitting on code reviews for a while and that I adressed all the issue commented there regards, Bapt --ucfHZChuBC0NsER/ Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iEYEARECAAYFAlPGbp8ACgkQ8kTtMUmk6EzOxQCguluCK/YzNWe6FuUSSvkKE1pp i+EAoItNzN4eB523mI7UtpijD8u0dCLG =lQ8g -----END PGP SIGNATURE----- --ucfHZChuBC0NsER/--