From owner-svn-src-all@FreeBSD.ORG  Tue Jul 12 19:00:57 2011
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 49BC3106566B;
	Tue, 12 Jul 2011 19:00:57 +0000 (UTC)
	(envelope-from tuexen@FreeBSD.org)
Received: from mail-n.franken.de (drew.ipv6.franken.de
	[IPv6:2001:638:a02:a001:20e:cff:fe4a:feaa])
	by mx1.freebsd.org (Postfix) with ESMTP id D49C58FC0C;
	Tue, 12 Jul 2011 19:00:56 +0000 (UTC)
Received: from [192.168.1.195] (p508FB201.dip.t-dialin.net [80.143.178.1])
	(Authenticated sender: macmic)
	by mail-n.franken.de (Postfix) with ESMTP id DD6A61C0B4612;
	Tue, 12 Jul 2011 21:00:54 +0200 (CEST)
Mime-Version: 1.0 (Apple Message framework v1084)
Content-Type: text/plain; charset=us-ascii
From: Michael Tuexen <tuexen@FreeBSD.org>
In-Reply-To: <4E1C8FBD.5050705@FreeBSD.org>
Date: Tue, 12 Jul 2011 21:00:53 +0200
Content-Transfer-Encoding: quoted-printable
Message-Id: <6252BB63-BA46-4045-ACFB-F1560D29D301@FreeBSD.org>
References: <201107121147.p6CBl8hY037547@svn.freebsd.org>
	<4E1C8FBD.5050705@FreeBSD.org>
To: Doug Barton <dougb@FreeBSD.org>
X-Mailer: Apple Mail (2.1084)
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
	src-committers@freebsd.org
Subject: Re: svn commit: r223947 - head/usr.bin/netstat
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
	user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 12 Jul 2011 19:00:57 -0000

On Jul 12, 2011, at 8:17 PM, Doug Barton wrote:

> On 07/12/2011 04:47, Michael Tuexen wrote:
>> Author: tuexen
>> Date: Tue Jul 12 11:47:08 2011
>> New Revision: 223947
>> URL: http://svn.freebsd.org/changeset/base/223947
>>=20
>> Log:
>>  Truncate link addresses like it is done for any
>>  other address type.
>=20
> The more IPv6 is used the less optimal this truncation becomes ...
I agree. But this patch does not change the display of IPv6 addresses.
It just handles one specific case like all the others.
I found this because the bug broke a tool which relies on the correct
formatting of the netstat output.

Best regards
Michael
>=20
>>  MFC after: 4 weeks
>>=20
>> Modified:
>>  head/usr.bin/netstat/if.c
>>=20
>> Modified: head/usr.bin/netstat/if.c
>> =
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D
>> --- head/usr.bin/netstat/if.c	Tue Jul 12 10:07:07 2011	=
(r223946)
>> +++ head/usr.bin/netstat/if.c	Tue Jul 12 11:47:08 2011	=
(r223947)
>> @@ -394,7 +394,7 @@ intpr(int interval1, u_long ifnetaddr, v
>> 				n =3D cp - sa->sa_data + 1;
>> 				cp =3D sa->sa_data;
>> 			hexprint:
>> -				while (--n >=3D 0)
>> +				while ((--n >=3D 0) && (m < 30))
>> 					m +=3D printf("%02x%c", *cp++ & =
0xff,
>> 						    n > 0 ? ':' : ' ');
>> 				m =3D 32 - m;
>>=20
>=20
>=20
>=20
> --=20
>=20
> 	Nothin' ever doesn't change, but nothin' changes much.
> 			-- OK Go
>=20
> 	Breadth of IT experience, and depth of knowledge in the DNS.
> 	Yours for the right price.  :)  http://SupersetSolutions.com/
>=20
>=20