From owner-svn-src-all@FreeBSD.ORG Tue Sep 10 18:26:35 2013 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id B4A7E78C; Tue, 10 Sep 2013 18:26:35 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from bigwig.baldwin.cx (bigwig.baldwin.cx [IPv6:2001:470:1f11:75::1]) (using TLSv1 with cipher ADH-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 888522057; Tue, 10 Sep 2013 18:26:35 +0000 (UTC) Received: from jhbbsd.localnet (unknown [209.249.190.124]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id 73E59B976; Tue, 10 Sep 2013 14:26:34 -0400 (EDT) From: John Baldwin To: Alexey Dokuchaev Subject: Re: svn commit: r255426 - in head: lib/libc/sys sys/compat/freebsd32 sys/compat/linux sys/compat/svr4 sys/dev/drm2/i915 sys/i386/ibcs2 sys/i386/linux sys/ia64/ia32 sys/kern sys/sparc64/sparc64 sys/sys ... Date: Tue, 10 Sep 2013 14:24:39 -0400 User-Agent: KMail/1.13.5 (FreeBSD/8.4-CBSD-20130906; KDE/4.5.5; amd64; ; ) References: <201309091812.r89IC0YH015840@svn.freebsd.org> <20130910092323.GA58955@FreeBSD.org> In-Reply-To: <20130910092323.GA58955@FreeBSD.org> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201309101424.39322.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (bigwig.baldwin.cx); Tue, 10 Sep 2013 14:26:34 -0400 (EDT) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Sep 2013 18:26:35 -0000 On Tuesday, September 10, 2013 5:23:23 am Alexey Dokuchaev wrote: > On Mon, Sep 09, 2013 at 06:12:00PM +0000, John Baldwin wrote: > > New Revision: 255426 > > URL: http://svnweb.freebsd.org/changeset/base/255426 > > > > Log: > > [...] > > To facilitate this, add a new parameter to vm_map_find() that specifies an > > optional maximum virtual address. While here, fix several callers of > > vm_map_find() to use a VMFS_* constant for the findspace argument instead > > of TRUE and FALSE. > > This commit breaks NVidia driver port, and (again) there was no corresponding > __FreeBSD_version bump. My bad, I completely missed the version bump. Userland consumers can use #ifdef MAP_32BIT which is why I didn't add one. > This is another recent incident with -CURRENT silently changing KPIs that are > publicly used. To be fair, these are fairly internal KPIs unlike, say, the cdevsw interface that is widely used in many drivers. You can count all of the internal and external users of this function on two hands. -- John Baldwin