From owner-svn-src-user@FreeBSD.ORG  Sun May 15 16:53:58 2011
Return-Path: <owner-svn-src-user@FreeBSD.ORG>
Delivered-To: svn-src-user@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 56E91106566C;
	Sun, 15 May 2011 16:53:58 +0000 (UTC) (envelope-from avg@FreeBSD.org)
Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140])
	by mx1.freebsd.org (Postfix) with ESMTP id 6566B8FC12;
	Sun, 15 May 2011 16:53:57 +0000 (UTC)
Received: from porto.topspin.kiev.ua (porto-e.starpoint.kiev.ua
	[212.40.38.100])
	by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id TAA14052;
	Sun, 15 May 2011 19:53:55 +0300 (EEST)
	(envelope-from avg@FreeBSD.org)
Received: from localhost.topspin.kiev.ua ([127.0.0.1])
	by porto.topspin.kiev.ua with esmtp (Exim 4.34 (FreeBSD))
	id 1QLeZm-0000JZ-Mx; Sun, 15 May 2011 19:53:54 +0300
Message-ID: <4DD00522.2010309@FreeBSD.org>
Date: Sun, 15 May 2011 19:53:54 +0300
From: Andriy Gapon <avg@FreeBSD.org>
User-Agent: Mozilla/5.0 (X11; U; FreeBSD amd64; en-US;
	rv:1.9.2.17) Gecko/20110503 Lightning/1.0b2 Thunderbird/3.1.10
MIME-Version: 1.0
To: Matthew Fleming <mdf356@gmail.com>
References: <201105151432.p4FEWtTw042031@svn.freebsd.org>	<20110515150759.GI111@hoeg.nl>	<4DCFFAFF.7020403@FreeBSD.org>
	<BANLkTi=m8aN2k4P+bZ8jakj++Ch39Xhn-g@mail.gmail.com>
In-Reply-To: <BANLkTi=m8aN2k4P+bZ8jakj++Ch39Xhn-g@mail.gmail.com>
X-Enigmail-Version: 1.1.2
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Cc: Ed Schouten <ed@80386.nl>,
	"src-committers@freebsd.org" <src-committers@FreeBSD.org>,
	"svn-src-user@freebsd.org" <svn-src-user@FreeBSD.org>
Subject: Re: svn commit: r221962 - in user/avg/xcpu/sys: kern sys
X-BeenThere: svn-src-user@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the experimental &quot; user&quot;
	src tree" <svn-src-user.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-user>,
	<mailto:svn-src-user-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-user>
List-Post: <mailto:svn-src-user@freebsd.org>
List-Help: <mailto:svn-src-user-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-user>,
	<mailto:svn-src-user-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 15 May 2011 16:53:58 -0000

on 15/05/2011 19:19 Matthew Fleming said the following:
> On Sunday, May 15, 2011, Andriy Gapon <avg@freebsd.org> wrote:
>> on 15/05/2011 18:07 Ed Schouten said the following:
>>> Hey Andriy,
>>>
>>> * Andriy Gapon <avg@FreeBSD.org>, 20110515 16:32:
>>>> -    if (IS_PANIC_THREAD())
>>>> +    if (THREAD_PANICED())
>>>
>>> Shouldn't this be called THREAD_PANICKED(), with the k, instead?
>>>
>>
>> Yes, it should be.  Thank you.
> 
> Shouldn't it be TD_IS_PANIC[K]ED to match many of the other checks
> like TD_IS_IDLETHREAD?  Or perhaps to avoid a spelling change,
> TD_IS_INPANIC?

I like both of your proposals.  Where have you been before? :)
Ok, let's now settle on one best name and I will do another rename, that's easy
to do.

-- 
Andriy Gapon