From owner-freebsd-questions@FreeBSD.ORG  Sat Jul 27 19:43:26 2013
Return-Path: <owner-freebsd-questions@FreeBSD.ORG>
Delivered-To: freebsd-questions@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTP id 7409E367
 for <freebsd-questions@freebsd.org>; Sat, 27 Jul 2013 19:43:26 +0000 (UTC)
 (envelope-from frank2@fjl.co.uk)
Received: from bs1.fjl.org.uk (bs1.fjl.org.uk [84.45.41.196])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id 24B8D225D
 for <freebsd-questions@freebsd.org>; Sat, 27 Jul 2013 19:43:25 +0000 (UTC)
Received: from [192.168.1.35] (mux.fjl.org.uk [62.3.120.246])
 (authenticated bits=0)
 by bs1.fjl.org.uk (8.14.4/8.14.4) with ESMTP id r6RJhNFr079620
 (version=TLSv1/SSLv3 cipher=DHE-DSS-CAMELLIA256-SHA bits=256 verify=NO)
 for <freebsd-questions@freebsd.org>; Sat, 27 Jul 2013 20:43:24 +0100 (BST)
 (envelope-from frank2@fjl.co.uk)
Message-ID: <51F422DB.2000205@fjl.co.uk>
Date: Sat, 27 Jul 2013 20:43:23 +0100
From: Frank Leonhardt <frank2@fjl.co.uk>
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64;
 rv:17.0) Gecko/20130620 Thunderbird/17.0.7
MIME-Version: 1.0
To: freebsd-questions@freebsd.org
Subject: Re: Delete a directory, crash the system
References: <CAHAXwYDPMrdY-TP-5T1_6M_ot4gY09jo2_Wi_REOmE=+u+_QuQ@mail.gmail.com>
 <CAGwOe2byRc4LVsyxvTJgxNGCbhvOEaeDXjmFJ7DoXThPQe1bcQ@mail.gmail.com>
 <CAHAXwYCj9AV8ZcDffNNGx-ivL=h_TK9zLQRTPknArX25HSfEag@mail.gmail.com>
 <CAGwOe2YCDRqHudovDB_Kz9WHppvB8v2L+0gkDnWgG88bgZTKSA@mail.gmail.com>
 <CAHAXwYCnRDQqgRcvaEE1BmSJYYOidoQzzUoHX_QWdyJzYO3kKw@mail.gmail.com>
 <51F3F290.9020004@cordula.ws>
 <CAHAXwYA7WfYP8OZBVf47xRsDp9N01U3rPLZwwj7PFqkPxm3oag@mail.gmail.com>
 <51F420ED.1050402@fjl.co.uk>
 <CAHAXwYArUStyGe600oyiYY3oT0rCwYn-UWqedg8+CHBPq0ZcUA@mail.gmail.com>
In-Reply-To: <CAHAXwYArUStyGe600oyiYY3oT0rCwYn-UWqedg8+CHBPq0ZcUA@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-Content-Filtered-By: Mailman/MimeDel 2.1.14
X-BeenThere: freebsd-questions@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: User questions <freebsd-questions.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-questions>, 
 <mailto:freebsd-questions-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-questions>
List-Post: <mailto:freebsd-questions@freebsd.org>
List-Help: <mailto:freebsd-questions-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-questions>, 
 <mailto:freebsd-questions-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 27 Jul 2013 19:43:26 -0000

On 27/07/2013 20:38, David Noel wrote:
>> I was going to raise an issue when the discussion had died down to a
>> concensus. I also don't think it's reasonable for the kernel to bomb
>> when it encounters corruption on a disk.
>>
>> If you want to patch it yourself, edit sys/ufs/ufs/ufs_vnops.c at around
>> line 2791 change:
>>
>>           if (dp->i_effnlink < 3)
>>                   panic("ufs_dirrem: Bad link count %d on parent",
>>                       dp->i_effnlink);
>>
>> To
>>
>>           if (dp->i_effnlink < 3) {
>>                   error = EINVAL;
>>                   goto out;
>>           }
>>
>> The ufs_link() call has a similar issue.
>>
>> I can't see why my mod will break anything, but there's always
>> unintended consequences. By returning invalid argument, any code above
>> it should already be handling that condition although the user will be
>> scratching their head wondering what's wrong with it. Returning ENOENT
>> or EACCES or ENOTDIR may be better ("No such directory", "Access denied"
>> or "Not a valid directory").
>>
>> The trouble is that it's tricky to test properly without finding a good
>> way to corrupt the link count :-)
>>
>> Regards, Frank.
> Cool. Thanks for the patch!
>
Sorry - forgot to mention that you use it entirely at your own risk!