From owner-freebsd-stable@FreeBSD.ORG Mon Nov 18 08:43:40 2013 Return-Path: Delivered-To: freebsd-stable@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 187A57A7 for ; Mon, 18 Nov 2013 08:43:40 +0000 (UTC) Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140]) by mx1.freebsd.org (Postfix) with ESMTP id 684B7273A for ; Mon, 18 Nov 2013 08:43:39 +0000 (UTC) Received: from porto.starpoint.kiev.ua (porto-e.starpoint.kiev.ua [212.40.38.100]) by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id KAA09318; Mon, 18 Nov 2013 10:43:11 +0200 (EET) (envelope-from avg@FreeBSD.org) Received: from localhost ([127.0.0.1]) by porto.starpoint.kiev.ua with esmtp (Exim 4.34 (FreeBSD)) id 1ViKQI-000Fqt-NJ; Mon, 18 Nov 2013 10:43:10 +0200 Message-ID: <5289D2FB.1010600@FreeBSD.org> Date: Mon, 18 Nov 2013 10:42:35 +0200 From: Andriy Gapon User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:24.0) Gecko/20100101 Thunderbird/24.1.0 MIME-Version: 1.0 To: Steven Hartland , hartzell@alerce.com, freebsd-stable@FreeBSD.org Subject: Re: Help with filing a [maybe] ZFS/mmap bug. References: <20967.760.95825.310085@gargle.gargle.HOWL><51E80B30.1090004@FreeBSD.org><20968.10645.880772.30501@gargle.gargle.HOWL><520202E5.30300@FreeBSD.org><20994.55913.93606.436124@gargle.gargle.HOWL> <21111.12085.958991.356982@gargle.gargle.HOWL> <4EB902F80CE84DD2BF36C85EF4CE8EF8@multiplay.co.uk> <5284B8A5.8040604@FreeBSD.org> <52889105.7040404@FreeBSD.org> <9A58D6B0691A4C1294883AD91F9D4743@multiplay.co.uk> In-Reply-To: <9A58D6B0691A4C1294883AD91F9D4743@multiplay.co.uk> X-Enigmail-Version: 1.6 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Nov 2013 08:43:40 -0000 on 17/11/2013 17:53 Steven Hartland said the following: > > ----- Original Message ----- From: "Andriy Gapon" >> - vm_page_clear_dirty(pp, off, nbytes); >> + if (nbytes != 0) >> + vm_page_clear_dirty(pp, off, nbytes); >> } >> break; > > Thanks Andriy, looking to test this here but 8.3 doesn't have a page_busy > method in zfs_vnops.c so I'm not sure how to proceed on this? Does it have vm_page_clear_dirty call? -- Andriy Gapon