From owner-freebsd-stable@FreeBSD.ORG Fri Dec 4 16:56:38 2009 Return-Path: Delivered-To: freebsd-stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 49C6E1065676; Fri, 4 Dec 2009 16:56:38 +0000 (UTC) (envelope-from lsantagostini@gmail.com) Received: from mail-iw0-f198.google.com (mail-iw0-f198.google.com [209.85.223.198]) by mx1.freebsd.org (Postfix) with ESMTP id D75678FC0A; Fri, 4 Dec 2009 16:56:37 +0000 (UTC) Received: by iwn36 with SMTP id 36so1673542iwn.3 for ; Fri, 04 Dec 2009 08:56:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=k1p6tREHkdafO4WUAWFw33K2o0LZnIj7NOC2V5aNOn0=; b=AW7l6OC+Dh5ISfgeXd839R6xCCKIt4xa3p3rZvayrNjKOsUY/kFdFntLfHZ1Bd4TKp WUPbF04OQPiN2zBiYjV6YAi8FaTPBGw/q3JRRPyu1iw3hMijJbKqeHsVM0oCzpvb8Rz9 lFMor4+7N+/aMwOKikg9J+nhME0dEjI+yu79w= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=Y2EGl0PByvNWghZWMlSTyJcbYA7bGiYNUP/yK1LCbDER6yBHjyE3dTwpc0yMlJvDuh YaQBz4prEolW5yVK+oNAVJGjZydoMVanADdVQNpuLLRbTt4vY3qhSnG/zm3NDIVg05Wu PniqF+nq29b28rdM9YGweXeuuG0+sSJRBm+Zg= MIME-Version: 1.0 Received: by 10.231.170.201 with SMTP id e9mr427806ibz.16.1259945797150; Fri, 04 Dec 2009 08:56:37 -0800 (PST) In-Reply-To: <200912041137.42917.jkim@FreeBSD.org> References: <9ab7eeeb0912021757g5f60a7edw3256e60e745c0c35@mail.gmail.com> <87tyw8o5xk.fsf@kobe.laptop> <9ab7eeeb0912031827vd32544fk996a65e871322091@mail.gmail.com> <200912041137.42917.jkim@FreeBSD.org> Date: Fri, 4 Dec 2009 13:56:37 -0300 Message-ID: <9ab7eeeb0912040856q2fcaf491g69d17de2193bfcb4@mail.gmail.com> From: Leonardo Santagostini To: Jung-uk Kim Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Cc: freebsd-current@freebsd.org, freebsd-stable@freebsd.org, Giorgos Keramidas Subject: Re: Could you please fix this ? X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Dec 2009 16:56:38 -0000 Ok, anyway thanks for your time. Best Regards Leonardo Santagostini 2009/12/4 Jung-uk Kim : > On Thursday 03 December 2009 09:27 pm, Leonardo Santagostini wrote: >> Sorry, but ive not backed up this file, instead of this, i will >> copy the entire function (in fact its very short) >> >> cpi_pcib_pci_attach(device_t dev) >> { >> =C2=A0 =C2=A0 struct acpi_pcib_softc *sc; >> =C2=A0 =C2=A0 ACPI_FUNCTION_TRACE((char *)(uintptr_t)__func__); >> >> =C2=A0 =C2=A0 if (device_get_unit(dev)=3D=3D2){ >> =C2=A0 =C2=A0 =C2=A0 =C2=A0 pci_write_config(dev, PCIR_COMMAND, PCIM_CMD= _MEMEN | >> PCIM_CMD_PORTEN, 1); >> =C2=A0 =C2=A0 =C2=A0 =C2=A0 pci_enable_busmaster(dev); >> =C2=A0 =C2=A0 =C2=A0 =C2=A0 pci_write_config(dev, PCIR_IOBASEL_1, 0xf0, = 1); >> =C2=A0 =C2=A0 =C2=A0 =C2=A0 pci_write_config(dev, PCIR_MEMBASE_1, 0xf020= , 2); >> =C2=A0 =C2=A0 =C2=A0 =C2=A0 pci_write_config(dev, PCIR_MEMLIMIT_1, 0xf02= 0, 2); >> =C2=A0 =C2=A0 =C2=A0 =C2=A0 pci_write_config(dev, PCIR_PMBASEL_1, 0xfff1= , 2); >> =C2=A0 =C2=A0 } >> =C2=A0 =C2=A0 if (device_get_unit(dev)=3D=3D3){ >> =C2=A0 =C2=A0 =C2=A0 =C2=A0 pci_write_config(dev, PCIR_COMMAND, PCIM_CMD= _MEMEN | >> PCIM_CMD_PORTEN, 1); >> =C2=A0 =C2=A0 =C2=A0 =C2=A0 pci_enable_busmaster(dev); >> =C2=A0 =C2=A0 =C2=A0 =C2=A0 pci_write_config(dev, PCIR_IOBASEL_1, 0xf0, = 1); >> =C2=A0 =C2=A0 =C2=A0 =C2=A0 pci_write_config(dev, PCIR_MEMBASE_1, 0xf030= , 2); >> =C2=A0 =C2=A0 =C2=A0 =C2=A0 pci_write_config(dev, PCIR_MEMLIMIT_1, 0xf03= 0, 2); >> =C2=A0 =C2=A0 =C2=A0 =C2=A0 pci_write_config(dev, PCIR_PMBASEL_1, 0xfff1= , 2); >> =C2=A0 =C2=A0 } >> >> =C2=A0 =C2=A0 pcib_attach_common(dev); >> =C2=A0 =C2=A0 sc =3D device_get_softc(dev); >> =C2=A0 =C2=A0 sc->ap_handle =3D acpi_get_handle(dev); >> =C2=A0 return (acpi_pcib_attach(dev, &sc->ap_prt, >> sc->ap_pcibsc.secbus)); } > > As mav@ pointed out yesterday, this hack is very specific to this > hardware. =C2=A0As jhb@ pointed out some time ago, this problem will be > properly addressed by his "multipass" device probing mechanism. > > Sorry, there's nothing we can commit ATM. > > Jung-uk Kim > >> Kind Regards >> Leonardo Santagostini >> >> 2009/12/3 Giorgos Keramidas : >> > On Thu, 3 Dec 2009 01:57:50 +0000, Leonardo Santagostini > wrote: >> >> Hello everybody, >> >> >> >> I was facing one big problem, i have a notebook, which is an >> >> Acer Aspire 5920. =C2=A0If you like i can send to you my messages >> >> file. >> >> >> >> Which is: >> >> >> >> Intel(R) Core(TM)2 Duo CPU =C2=A0 =C2=A0 T5550 =C2=A0@ 1.83GHz (1833.= 48-MHz >> >> 686-class CPU) Intel(R) PRO/Wireless 3945ABG >> >> Broadcom NetLink Gigabit Ethernet Controller >> >> 2 Gigs RAM >> >> 160 Gigs SATA >> >> >> >> The point was: >> >> With ACPI disabled, i managed to boot but without WIFI; and with >> >> ACPI enabled, the boot process hanged up all times. >> >> >> >> I fixed this adding >> >> >> >> =C2=A0 =C2=A0 if (device_get_unit(dev)=3D=3D2){ >> >> =C2=A0 =C2=A0 =C2=A0 =C2=A0 pci_write_config(dev, PCIR_COMMAND, PCIM_= CMD_MEMEN | >> >> PCIM_CMD_PORTEN, 1); pci_enable_busmaster(dev); >> >> =C2=A0 =C2=A0 =C2=A0 =C2=A0 pci_write_config(dev, PCIR_IOBASEL_1, 0xf= 0, 1); >> >> =C2=A0 =C2=A0 =C2=A0 =C2=A0 pci_write_config(dev, PCIR_MEMBASE_1, 0xf= 020, 2); >> >> =C2=A0 =C2=A0 =C2=A0 =C2=A0 pci_write_config(dev, PCIR_MEMLIMIT_1, 0x= f020, 2); >> >> =C2=A0 =C2=A0 =C2=A0 =C2=A0 pci_write_config(dev, PCIR_PMBASEL_1, 0xf= ff1, 2); >> >> =C2=A0 =C2=A0 } >> >> =C2=A0 =C2=A0 if (device_get_unit(dev)=3D=3D3){ >> >> =C2=A0 =C2=A0 =C2=A0 =C2=A0 pci_write_config(dev, PCIR_COMMAND, PCIM_= CMD_MEMEN | >> >> PCIM_CMD_PORTEN, 1); pci_enable_busmaster(dev); >> >> =C2=A0 =C2=A0 =C2=A0 =C2=A0 pci_write_config(dev, PCIR_IOBASEL_1, 0xf= 0, 1); >> >> =C2=A0 =C2=A0 =C2=A0 =C2=A0 pci_write_config(dev, PCIR_MEMBASE_1, 0xf= 030, 2); >> >> =C2=A0 =C2=A0 =C2=A0 =C2=A0 pci_write_config(dev, PCIR_MEMLIMIT_1, 0x= f030, 2); >> >> =C2=A0 =C2=A0 =C2=A0 =C2=A0 pci_write_config(dev, PCIR_PMBASEL_1, 0xf= ff1, 2); >> >> =C2=A0 =C2=A0 } >> >> >> >> to /usr/src/sys/dev/acpica/acpi_pcib_pci.c running on a >> >> 8.0-RELEASE >> >> >> >> I was able to fix it by my way but many people cant do it, so, i >> >> would really appreciate if you can add this piece of code. >> > >> > Hi Leonardo. >> > >> > Jung-uk Kim has done a lot of ACPI-related work, so he will >> > probably know if the change is ok to commit to stable/8. =C2=A0I've >> > added him to the thread, so he can let us know what he thinks of >> > the change. =C2=A0Can you please post a diff that also shows _where_ >> > the changes have to be installed in our current version of >> > src/sys/dev/acpica/acpi_pcib_pci.c for 8.0-RELEASE? >