From owner-svn-src-head@FreeBSD.ORG  Fri Jul 31 17:00:52 2009
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 50D18106570E;
	Fri, 31 Jul 2009 17:00:52 +0000 (UTC) (envelope-from sam@errno.com)
Received: from ebb.errno.com (ebb.errno.com [69.12.149.25])
	by mx1.freebsd.org (Postfix) with ESMTP id 25C468FC28;
	Fri, 31 Jul 2009 17:00:51 +0000 (UTC) (envelope-from sam@errno.com)
Received: from ice.local ([10.0.0.115]) (authenticated bits=0)
	by ebb.errno.com (8.13.6/8.12.6) with ESMTP id n6VH0TSs090846
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);
	Fri, 31 Jul 2009 10:00:29 -0700 (PDT) (envelope-from sam@errno.com)
Message-ID: <4A73232D.8050605@errno.com>
Date: Fri, 31 Jul 2009 10:00:29 -0700
From: Sam Leffler <sam@errno.com>
User-Agent: Thunderbird 2.0.0.22 (Macintosh/20090605)
MIME-Version: 1.0
To: Ed Schouten <ed@80386.nl>
References: <200907271351.n6RDptNX002239@svn.freebsd.org>
	<20090731150328.GN1292@hoeg.nl>
In-Reply-To: <20090731150328.GN1292@hoeg.nl>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-DCC-sonic.net-Metrics: ebb.errno.com; whitelist
Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org,
	src-committers@FreeBSD.org, Rui Paulo <rpaulo@FreeBSD.org>
Subject: Re: svn commit: r195907 - in head/sys: amd64/amd64 i386/i386
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
	<svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 31 Jul 2009 17:00:53 -0000

Ed Schouten wrote:
> * Rui Paulo <rpaulo@FreeBSD.org> wrote:
>> Refine the MacBook hack to only match early models that have Intel ICH.
> ...
>> -		if (strncmp(sysenv, "MacBook", 7) == 0) {
>> +		if (strncmp(sysenv, "MacBook1,1", 10) == 0 ||
>> +		    strncmp(sysenv, "MacBookPro1,1", 13) == 0 ||
>> +		    strncmp(sysenv, "MacBookPro1,2", 13) == 0 ||
>> +		    strncmp(sysenv, "Macmini1,1", 10) == 0) {
> 
> Yay -- this change broke FreeBSD on my MacBook3,1. Could we please add
> MacBook3,1 to this list before releasing 8.0?
> 

A hack like this deserves a loader tunable to set the list or, perhaps 
easier, an extra model ID to allow workaround w/o rebuilding (e.g. for 
doing an install).

	Sam