From owner-cvs-all@FreeBSD.ORG  Mon Apr 14 20:15:45 2008
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 1A215106566B;
	Mon, 14 Apr 2008 20:15:45 +0000 (UTC)
	(envelope-from rwatson@FreeBSD.org)
Received: from cyrus.watson.org (cyrus.watson.org [209.31.154.42])
	by mx1.freebsd.org (Postfix) with ESMTP id DF1FF8FC1D;
	Mon, 14 Apr 2008 20:15:44 +0000 (UTC)
	(envelope-from rwatson@FreeBSD.org)
Received: from fledge.watson.org (fledge.watson.org [209.31.154.41])
	by cyrus.watson.org (Postfix) with ESMTP id 8B48446B1E;
	Mon, 14 Apr 2008 16:15:44 -0400 (EDT)
Date: Mon, 14 Apr 2008 21:15:44 +0100 (BST)
From: Robert Watson <rwatson@FreeBSD.org>
X-X-Sender: robert@fledge.watson.org
To: Randall Stewart <rrs@FreeBSD.org>
In-Reply-To: <200804141806.m3EI64St043794@repoman.freebsd.org>
Message-ID: <20080414210941.U72408@fledge.watson.org>
References: <200804141806.m3EI64St043794@repoman.freebsd.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/kern uipc_socket.c src/sys/sys protosw.h 
 socket.h
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 14 Apr 2008 20:15:45 -0000


On Mon, 14 Apr 2008, Randall Stewart wrote:

>  Add pru_flush routine so a transport can
>  flush itself during Shutdown
>
>  MFC after:      1 week

I'm not sure this is an MFCable change because:

(a) The new function pointer is inserted in the middle of the data protosw
     data structure, changing the interpretation of existing compiled protosw
     structures.

(b) Even if they were at the end of the structure, existing compiled protocols
     might well have garbage (or un-related data) beyond the end of the data
     structure, leading to a non-NULL pointer that is not a pointer to a flush
     function.

Robert N M Watson
Computer Laboratory
University of Cambridge