From owner-freebsd-current@FreeBSD.ORG  Thu Aug 29 14:58:10 2013
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTP id 614A359A;
 Thu, 29 Aug 2013 14:58:10 +0000 (UTC) (envelope-from jhb@freebsd.org)
Received: from bigwig.baldwin.cx (bigwig.baldwin.cx [IPv6:2001:470:1f11:75::1])
 (using TLSv1 with cipher ADH-CAMELLIA256-SHA (256/256 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id 3757E2DBB;
 Thu, 29 Aug 2013 14:58:10 +0000 (UTC)
Received: from jhbbsd.localnet (unknown [38.105.238.108])
 by bigwig.baldwin.cx (Postfix) with ESMTPSA id 45552B979;
 Thu, 29 Aug 2013 10:58:09 -0400 (EDT)
From: John Baldwin <jhb@freebsd.org>
To: freebsd-current@freebsd.org
Subject: Re: How to best overload the fileops ?
Date: Thu, 29 Aug 2013 10:36:39 -0400
User-Agent: KMail/1.13.5 (FreeBSD/8.2-CBSD-20110714-p28; KDE/4.5.5; amd64; ; )
References: <521508F4.6030502@rawbw.com>
 <1377290165.1111.85.camel@revolution.hippie.lan> <5217DFC0.7070708@rawbw.com>
In-Reply-To: <5217DFC0.7070708@rawbw.com>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Message-Id: <201308291036.39807.jhb@freebsd.org>
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7
 (bigwig.baldwin.cx); Thu, 29 Aug 2013 10:58:09 -0400 (EDT)
Cc: Mateusz Guzik <mjguzik@gmail.com>, current@freebsd.org,
 Ian Lepore <ian@freebsd.org>, Roman Divacky <rdivacky@freebsd.org>,
 Yuri <yuri@rawbw.com>, John-Mark Gurney <jmg@funkthat.com>
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
 <freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-current>, 
 <mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
 <mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 29 Aug 2013 14:58:10 -0000

On Friday, August 23, 2013 6:18:40 pm Yuri wrote:
> On 08/23/2013 13:36, Ian Lepore wrote:
> > I think the point is that devfs_ops_f provides several devfs-specific
> > methods and then "inherits" the rest by referencing the standard
> > vn_whatever functions.  Since John recommended that you expose the
> > fo_whatever methods, I think he's suggesting you build your ops table by
> > providing your own close method and fill in the rest of the table with
> > the now-exposed kqueue ops methods.
> 
> So you are suggesting to just make kqueue fileops public? This was my 
> first suggestion, and this was rejected by Roman Divacky (who was 
> supposed to check it in) as very ugly. I did this through the method 
> kqueue_ops(), not directly though.
> 
> So can we agree on way to be used here?

Making the individual kqueue methods public is more consistent with other
uses in the tree (notably devfs), so I think that is the best way.

-- 
John Baldwin