From owner-svn-src-all@FreeBSD.ORG  Mon Dec 15 21:38:25 2014
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id AFBF1217;
 Mon, 15 Dec 2014 21:38:25 +0000 (UTC)
Received: from mail-ig0-x233.google.com (mail-ig0-x233.google.com
 [IPv6:2607:f8b0:4001:c05::233])
 (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits))
 (Client CN "smtp.gmail.com",
 Issuer "Google Internet Authority G2" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 74A13DF6;
 Mon, 15 Dec 2014 21:38:25 +0000 (UTC)
Received: by mail-ig0-f179.google.com with SMTP id r2so5897428igi.6
 for <multiple recipients>; Mon, 15 Dec 2014 13:38:25 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=mime-version:sender:in-reply-to:references:from:date:message-id
 :subject:to:cc:content-type;
 bh=sIVo5vUZkSJQOYXk5S1PmQ1fI/Pl0iAT8cAgOAAk5pA=;
 b=zpoAIVNpjhi1Eot/hQ8ZNo74Tgc9/YDPcIPMCgNb80JhWJR+s9+ZSMW1yhDHH0KPB5
 uoRJgrt0s45ztwQAWoxrtyOq0E9biz9FDAXqEqDojI/VtoLyrWDB6zswM1NpKxcgZ7nU
 0Yj6XHj+x15YXueH+IL9f+WOAvGJ5VyUApYYy4lPB2Xntq/Y1OFyeYw0l1VcV58wjmyO
 ff1h6uUeLcs/tPk6K5kwATe62OAIs7ruRoR2EdtK4u6OyzQxuRpFScrxn32SU3mcdvZ4
 tbmDgxTkPkp3tVA1pweWKqBP5XlkL9vnSs2GXNrIfhfOjvEB5Q8aDRs0Eufr+QbVoOfD
 CqIQ==
X-Received: by 10.50.143.101 with SMTP id sd5mr20343187igb.40.1418679504857;
 Mon, 15 Dec 2014 13:38:24 -0800 (PST)
MIME-Version: 1.0
Sender: carpeddiem@gmail.com
Received: by 10.107.0.85 with HTTP; Mon, 15 Dec 2014 13:38:04 -0800 (PST)
In-Reply-To: <CAG=rPVc3GJpCGSBUD4-TgfKG2HVHt=oEr71G_twChx6_x7tBGQ@mail.gmail.com>
References: <201412151425.sBFEPhhs009026@svn.freebsd.org>
 <CAG=rPVc3GJpCGSBUD4-TgfKG2HVHt=oEr71G_twChx6_x7tBGQ@mail.gmail.com>
From: Ed Maste <emaste@freebsd.org>
Date: Mon, 15 Dec 2014 16:38:04 -0500
X-Google-Sender-Auth: cOH6ljH6XxEyPnyErww6u1vnGro
Message-ID: <CAPyFy2D3GHFk=daKia6psn-TjjtGthzAiYHghVuPk778nXqZrw@mail.gmail.com>
Subject: Re: svn commit: r275804 - head/gnu/usr.bin/cc/cc1plus
To: Craig Rodrigues <rodrigc@freebsd.org>
Content-Type: text/plain; charset=UTF-8
Cc: "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>,
 "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>,
 "src-committers@freebsd.org" <src-committers@freebsd.org>
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 15 Dec 2014 21:38:25 -0000

On 15 December 2014 at 16:04, Craig Rodrigues <rodrigc@freebsd.org> wrote:
>
>
> On Mon, Dec 15, 2014 at 6:25 AM, Ed Maste <emaste@freebsd.org> wrote:
>>
>>  cfns.h: cfns.gperf
>>         gperf -o -C -E -k '1-6,$$' -j1 -D -N 'libc_name_p' -L ANSI-C \
>> -           ${.ALLSRC} > ${.TARGET}
>> +           ${.ALLSRC} > ${.TARGET} || (rm -f ${.TARGET}; false)
>>
>
> Instead of removing the target you could have done something like:
>
>  cfns.h: cfns.gperf
>         gperf -o -C -E -k '1-6,$$' -j1 -D -N 'libc_name_p' -L ANSI-C \
>            ${.ALLSRC} > ${.TARGET}_temp
>            mv ${.TARGET}_temp ${.TARGET}

Yeah.  There are already examples of both approaches in the tree; I
don't see a reason to strongly prefer one over the other.