From owner-svn-src-all@FreeBSD.ORG Tue Jan 27 02:26:56 2015 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id E92EA402; Tue, 27 Jan 2015 02:26:56 +0000 (UTC) Received: from mail-pa0-x22d.google.com (mail-pa0-x22d.google.com [IPv6:2607:f8b0:400e:c03::22d]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id AFAD19D2; Tue, 27 Jan 2015 02:26:56 +0000 (UTC) Received: by mail-pa0-f45.google.com with SMTP id et14so15328775pad.4; Mon, 26 Jan 2015 18:26:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=content-type:mime-version:subject:from:in-reply-to:date:cc :message-id:references:to; bh=qLaFCD0CS8ukXPnx7a7tSO39xbrcxUEJFp9Nd8ZVg5M=; b=UQYl53jGZagjpAzuaEwJBqvuJrLoaDRyFlVE7FbaM5RhucfR8fee9k4cH0blCwa5On qXf/i1IW/kzXQFxU7DQ8ay1ocoq9KJuX2n3lNKPd5+yGsGxK5zd139lzMevkhacN4mED LiBfxe9LyvdXaf1PRhA8jqUM1xVMcpa6Q3cltVimGW72I3T8pMc4LLqrHk6RYRg46o66 dWaASEGTRerweJEqcBKr7q2q1TTW8sTSNSOJHdqfCPDlomZ3SP+NDLoBmK1F12dHBT/f QFSbgxgV6F06ZkH1pftAqH8OC6bnyZ5G+ldhcuNbSfsgr6Pwz/oDjMZkpo1wX2kjV28k Jjxg== X-Received: by 10.68.222.130 with SMTP id qm2mr39731236pbc.44.1422325616231; Mon, 26 Jan 2015 18:26:56 -0800 (PST) Received: from ?IPv6:2601:8:ab80:7d6:bc82:b31b:4ccc:789f? ([2601:8:ab80:7d6:bc82:b31b:4ccc:789f]) by mx.google.com with ESMTPSA id qp4sm10917331pbc.63.2015.01.26.18.26.55 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 26 Jan 2015 18:26:55 -0800 (PST) Content-Type: multipart/signed; boundary="Apple-Mail=_15D0C615-AC0B-4CBF-9F68-13BCEC35A1B2"; protocol="application/pgp-signature"; micalg=pgp-sha512 Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\)) Subject: Re: svn commit: r277737 - in head: etc/pam.d tools/build/mk From: Garrett Cooper In-Reply-To: <86fvax91cy.fsf@nine.des.no> Date: Mon, 26 Jan 2015 18:26:54 -0800 Message-Id: References: <201501260850.t0Q8oDna015719@svn.freebsd.org> <86fvax91cy.fsf@nine.des.no> To: =?iso-8859-1?Q?Dag-Erling_Sm=F8rgrav?= X-Mailer: Apple Mail (2.1878.6) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers , Garrett Cooper X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Jan 2015 02:26:57 -0000 --Apple-Mail=_15D0C615-AC0B-4CBF-9F68-13BCEC35A1B2 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=windows-1252 On Jan 26, 2015, at 4:23, Dag-Erling Sm=F8rgrav wrote: > Garrett Cooper writes: >> Log: >> Honor MK_ACCT with etc/pam.d/atrun >=20 > The correct idiom would be I disagree for a few reasons: 1. style.Makefile(9) makes no mention of having to use an idiom over the = other. 2. The likelihood of typos creeping into Makefiles is greater with the = _foo=3D idiom. 3. It creates unnecessary local variables =97 especially when appending = is so easy to do. 4. It=92s more difficult when backporting changes to do it with the = variable method =97 especially if context around the line modified has = changed a great deal. --Apple-Mail=_15D0C615-AC0B-4CBF-9F68-13BCEC35A1B2 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQEcBAEBCgAGBQJUxvduAAoJEMZr5QU6S73enfIH/1pLmfrXzfKUjFRM+FhCqZf4 3gxJ/wemz8jTiQDfwo2Lhhq7PqK2UmtIEaVfF6X6nsF/9CcXbO7cu0ESKn5KC4U/ 7C1GVtYdUzp++Fy1L2YfexPgIOy8+cOYHyI/BXPEp2mKsOFyCtSBFnwQlYaAK5P3 +2Vqb2a5mnuwE9adRwGyJPrQjW7KQVNDC8PmkzyAC/YZHXtYnU3HpvLw0khQ0kgm LhMC423IfJ/74xEu7IJeq0ZGqPY0Ix3n3WcR/qwSFMk4KeI1WRxs9F5JQ/js6iaE W0yLn7cJXhKtBOARy5Mdn58ocx0F+kUp3bnquyVilwu2phmDs9WpR3Kn7hSXDkY= =SM3W -----END PGP SIGNATURE----- --Apple-Mail=_15D0C615-AC0B-4CBF-9F68-13BCEC35A1B2--