From owner-svn-src-head@FreeBSD.ORG  Thu Apr 11 07:59:34 2013
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115])
 by hub.freebsd.org (Postfix) with ESMTP id 6D15A98A;
 Thu, 11 Apr 2013 07:59:34 +0000 (UTC)
 (envelope-from brde@optusnet.com.au)
Received: from mail04.syd.optusnet.com.au (mail04.syd.optusnet.com.au
 [211.29.132.185])
 by mx1.freebsd.org (Postfix) with ESMTP id DCE208D9;
 Thu, 11 Apr 2013 07:59:33 +0000 (UTC)
Received: from c211-30-173-106.carlnfd1.nsw.optusnet.com.au
 (c211-30-173-106.carlnfd1.nsw.optusnet.com.au [211.30.173.106])
 by mail04.syd.optusnet.com.au (8.13.1/8.13.1) with ESMTP id r3B7xOXI002983
 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);
 Thu, 11 Apr 2013 17:59:26 +1000
Date: Thu, 11 Apr 2013 17:59:24 +1000 (EST)
From: Bruce Evans <brde@optusnet.com.au>
X-X-Sender: bde@besplex.bde.org
To: Gleb Smirnoff <glebius@freebsd.org>
Subject: Re: svn commit: r249355 - head/lib/libkvm
In-Reply-To: <201304110730.r3B7Uo6d067302@svn.freebsd.org>
Message-ID: <20130411175308.Q1435@besplex.bde.org>
References: <201304110730.r3B7Uo6d067302@svn.freebsd.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
X-Optus-CM-Score: 0
X-Optus-CM-Analysis: v=2.0 cv=Ov0XUFDt c=1 sm=1 a=YIxocstYFt4A:10
 a=kj9zAlcOel0A:10 a=PO7r1zJSAAAA:8 a=JzwRw_2MAAAA:8 a=RPTfz7_hRNcA:10
 a=iKLQVopRUfNpZhVUvFYA:9 a=CjuIK1q_8ugA:10 a=TEtd8y5WR3g2ypngnwZWYw==:117
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
 src-committers@freebsd.org
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 11 Apr 2013 07:59:34 -0000

> Log:
>  Include types.h for C99 uintXX_t types.

This adds namespace pollution that was carefully left out.

> Modified:
>  head/lib/libkvm/kvm.h
>
> Modified: head/lib/libkvm/kvm.h
> ==============================================================================
> --- head/lib/libkvm/kvm.h	Thu Apr 11 07:02:27 2013	(r249354)
> +++ head/lib/libkvm/kvm.h	Thu Apr 11 07:30:49 2013	(r249355)
> @@ -34,7 +34,7 @@
> #define	_KVM_H_
>
> #include <sys/cdefs.h>
> -#include <sys/_types.h>

The __uintXX_t types are declared here, and should be used, like the
__Xsize_t types already are.

> +#include <sys/types.h>
> #include <nlist.h>
>
> /* Default version symbol. */
>

Hmm, I never got around to committing the cleaning of <nlist.h>.  It only
takes 1 forward declaration and perhaps fixing clients that depend on the
pollution.

% Index: kvm.h
% ===================================================================
% RCS file: /home/ncvs/src/lib/libkvm/kvm.h,v
% retrieving revision 1.16
% diff -u -2 -r1.16 kvm.h
% --- kvm.h	13 Oct 2003 04:44:55 -0000	1.16
% +++ kvm.h	13 Oct 2003 04:46:29 -0000
% @@ -40,5 +40,4 @@
%  #include <sys/cdefs.h>
%  #include <sys/_types.h>
% -#include <nlist.h>
% 
%  /* Default version symbol. */
% @@ -59,4 +58,5 @@
% 
%  struct kinfo_proc;
% +struct nlist;
%  struct proc;
%

Bruce