From owner-cvs-all  Fri Mar  6 12:19:35 1998
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Received: (from majordom@localhost)
          by hub.freebsd.org (8.8.8/8.8.8) id MAA18993
          for cvs-all-outgoing; Fri, 6 Mar 1998 12:19:35 -0800 (PST)
          (envelope-from owner-cvs-all@FreeBSD.ORG)
Received: from burka.rdy.com (dima@burka.rdy.com [205.149.163.30])
          by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id MAA18952;
          Fri, 6 Mar 1998 12:19:12 -0800 (PST)
          (envelope-from dima@burka.rdy.com)
Received: by burka.rdy.com id MAA08880;
  (8.8.8/RDY) Fri, 6 Mar 1998 12:17:53 -0800 (PST)
Message-Id: <199803062017.MAA08880@burka.rdy.com>
Subject: Re: cvs commit: src/gnu/usr.bin/sort sort.c
In-Reply-To: <199803062012.VAA13861@gvr.gvr.org> from Guido van Rooij at "Mar 6, 98 09:12:40 pm"
To: guido@gvr.org (Guido van Rooij)
Date: Fri, 6 Mar 1998 12:17:53 -0800 (PST)
Cc: dima@best.net, ache@nagual.pp.ru, guido@FreeBSD.ORG,
        cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-gnu@FreeBSD.ORG
X-Class: Fast
Organization: HackerDome
Reply-To: dima@best.net
From: dima@best.net (Dima Ruban)
X-Mailer: ELM [version 2.4ME+ PL38 (25)]
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk

Guido van Rooij writes:
> > 
> > Maybe tempname() should check whether the file exsists, and if it does -
> > generate a new temp filename?
> > Fix is rather trivial.
> 
> No. This will still give you an obvious race. Actually, sort.c should use
> mkstemp(), but I did want to change as little as possible to the code.

Or mkstemp() :-)

> 
> -Guido
> 

-- dima

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message