From owner-svn-src-all@FreeBSD.ORG Mon Dec 15 22:30:32 2014 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 5F82A5B7; Mon, 15 Dec 2014 22:30:32 +0000 (UTC) Received: from elvis.mu.org (elvis.mu.org [192.203.228.196]) by mx1.freebsd.org (Postfix) with ESMTP id 3F15065C; Mon, 15 Dec 2014 22:30:32 +0000 (UTC) Received: from u10-2-32-011.office.norse-data.com (unknown [50.204.88.51]) by elvis.mu.org (Postfix) with ESMTPSA id 53E19341F83D; Mon, 15 Dec 2014 14:30:31 -0800 (PST) Message-ID: <548F6107.7030509@freebsd.org> Date: Mon, 15 Dec 2014 14:30:31 -0800 From: Alfred Perlstein Organization: FreeBSD User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: Craig Rodrigues , Ed Maste Subject: Re: svn commit: r275804 - head/gnu/usr.bin/cc/cc1plus References: <201412151425.sBFEPhhs009026@svn.freebsd.org> In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.18-1 Cc: "svn-src-head@freebsd.org" , "svn-src-all@freebsd.org" , "src-committers@freebsd.org" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Dec 2014 22:30:32 -0000 On 12/15/14 1:44 PM, Craig Rodrigues wrote: > > > On Mon, Dec 15, 2014 at 1:38 PM, Ed Maste > wrote: > > > > cfns.h: cfns.gperf > > gperf -o -C -E -k '1-6,$$' -j1 -D -N 'libc_name_p' -L > ANSI-C \ > > ${.ALLSRC} > ${.TARGET}_temp > > mv ${.TARGET}_temp ${.TARGET} > > Yeah. There are already examples of both approaches in the tree; I > don't see a reason to strongly prefer one over the other. > > > For very large build systems, sometimes it is easier to debug > weird build problems when the make operations do not have > conditional logic in them. +1 > Also, not removing temporary files upon failure > makes things easier to debug. +100 > > -- > Craig