From owner-svn-src-head@FreeBSD.ORG  Thu Apr 11 09:14:20 2013
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@FreeBSD.org
Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115])
 by hub.freebsd.org (Postfix) with ESMTP id 9F461CCB;
 Thu, 11 Apr 2013 09:14:20 +0000 (UTC)
 (envelope-from glebius@FreeBSD.org)
Received: from cell.glebius.int.ru (glebius.int.ru [81.19.69.10])
 by mx1.freebsd.org (Postfix) with ESMTP id 2A2E5CE8;
 Thu, 11 Apr 2013 09:14:19 +0000 (UTC)
Received: from cell.glebius.int.ru (localhost [127.0.0.1])
 by cell.glebius.int.ru (8.14.6/8.14.6) with ESMTP id r3B9EIIS068388;
 Thu, 11 Apr 2013 13:14:18 +0400 (MSK)
 (envelope-from glebius@FreeBSD.org)
Received: (from glebius@localhost)
 by cell.glebius.int.ru (8.14.6/8.14.6/Submit) id r3B9EIlQ068387;
 Thu, 11 Apr 2013 13:14:18 +0400 (MSK)
 (envelope-from glebius@FreeBSD.org)
X-Authentication-Warning: cell.glebius.int.ru: glebius set sender to
 glebius@FreeBSD.org using -f
Date: Thu, 11 Apr 2013 13:14:18 +0400
From: Gleb Smirnoff <glebius@FreeBSD.org>
To: Bruce Evans <brde@optusnet.com.au>
Subject: Re: svn commit: r249355 - head/lib/libkvm
Message-ID: <20130411091418.GW76816@FreeBSD.org>
References: <201304110730.r3B7Uo6d067302@svn.freebsd.org>
 <20130411175308.Q1435@besplex.bde.org>
 <20130411082457.GS76816@FreeBSD.org>
 <20130411184049.W1641@besplex.bde.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=koi8-r
Content-Disposition: inline
In-Reply-To: <20130411184049.W1641@besplex.bde.org>
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org,
 src-committers@FreeBSD.org
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 11 Apr 2013 09:14:20 -0000

On Thu, Apr 11, 2013 at 06:49:02PM +1000, Bruce Evans wrote:
B> > On Thu, Apr 11, 2013 at 05:59:24PM +1000, Bruce Evans wrote:
B> > B> > Modified:
B> > B> >  head/lib/libkvm/kvm.h
B> > B> >
B> > B> > Modified: head/lib/libkvm/kvm.h
B> > B> > ==============================================================================
B> > B> > --- head/lib/libkvm/kvm.h	Thu Apr 11 07:02:27 2013	(r249354)
B> > B> > +++ head/lib/libkvm/kvm.h	Thu Apr 11 07:30:49 2013	(r249355)
B> > B> > @@ -34,7 +34,7 @@
B> > B> > #define	_KVM_H_
B> > B> >
B> > B> > #include <sys/cdefs.h>
B> > B> > -#include <sys/_types.h>
B> > B>
B> > B> The __uintXX_t types are declared here, and should be used, like the
B> > B> __Xsize_t types already are.
B> >
B> > Why non-standard types should be used instead of standard ones?
B> 
B> Sometimes because the namespace doesn't allow the standard ones, but
B> here I was just saying to typedef just the standard ones that you need
B> (only uint64_t?) as is done for size_t and ssize_t.  Including
B> <sys/types.h> also turns the careful ifdefs for the latter into
B> no-ops.

What was the reason to avoid including types.h and typedefing size_t
and ssize_t manually?

-- 
Totus tuus, Glebius.