From owner-freebsd-pf@FreeBSD.ORG Wed Jun 20 00:05:11 2007 Return-Path: X-Original-To: freebsd-pf@freebsd.org Delivered-To: freebsd-pf@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 6D3B116A474 for ; Wed, 20 Jun 2007 00:05:11 +0000 (UTC) (envelope-from nate@root.org) Received: from root.org (root.org [67.118.192.226]) by mx1.freebsd.org (Postfix) with ESMTP id 508C913C448 for ; Wed, 20 Jun 2007 00:05:11 +0000 (UTC) (envelope-from nate@root.org) Received: (qmail 46818 invoked from network); 19 Jun 2007 16:06:31 -0000 Received: from ppp-71-139-42-13.dsl.snfc21.pacbell.net (HELO ?10.0.0.15?) (nate-mail@71.139.42.13) by root.org with ESMTPA; 19 Jun 2007 16:06:31 -0000 Message-ID: <4677FF00.4060506@root.org> Date: Tue, 19 Jun 2007 09:06:24 -0700 From: Nate Lawson User-Agent: Thunderbird 2.0.0.0 (X11/20070511) MIME-Version: 1.0 To: Eygene Ryabinkin References: <200706160347.33331.max@love2party.net> <20070617094126.GT3779@void.codelabs.ru> <200706171717.21585.max@love2party.net> <20070619074150.GC26920@void.codelabs.ru> In-Reply-To: <20070619074150.GC26920@void.codelabs.ru> X-Enigmail-Version: 0.95.0 Content-Type: text/plain; charset=KOI8-R Content-Transfer-Encoding: 7bit Cc: freebsd-pf@freebsd.org Subject: Re: pf 4.1 Update available for testing X-BeenThere: freebsd-pf@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Technical discussion and general questions about packet filter \(pf\)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Jun 2007 00:05:11 -0000 Eygene Ryabinkin wrote: > Max, good day. > > Sun, Jun 17, 2007 at 05:17:14PM +0200, Max Laier wrote: >>> I glanced over the new code and found that no changes were >>> introduced to the altq_subr.c. And there was rather old issue >>> I found in April: non-initialised callback due to Nate Lawson's >>> changes in handling the changing CPU frequencies. >>> >>> Looks like it is still living in the code. My original posting >>> is at >>> http://lists.freebsd.org/pipermail/freebsd-current/2007-April/071652.html >>> >>> Could you please take a look? >> Are you saying that the patch in that mail fixes things for you? I recall >> the discussion vaguely, but somehow dropped out of it - sorry. > > Yes, the patch fixed the kernel crash for me. Just tested on the > -CURRENT that is about a week old without my patch: it crashes. > The easiest way to test it is to start the machine without ALTQ > statements in the pf.conf, wait a while for the CPU frequency change > and then to enable ALTQ in the pf.conf. The only needed statements > are the 'altq' for the acrtive interface, one does not need any > altq-related statements for the filtering rules. This sequence > provokes the ALTQ's cpufreq handler to be invoked and the machclk_freq > to be initialized to some value. When ALTQ will be enabled, the > callback won't be initialized. And I am almost immediately catching > the kernel fault in the softclock, due to the bad callback. > > With my patch the problem goes away. Just checked ;)) If this works for you, I'm ok with Max committing it. -- Nate