From owner-svn-src-all@FreeBSD.ORG  Mon Dec 15 23:01:35 2014
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 8EEC5FC;
 Mon, 15 Dec 2014 23:01:35 +0000 (UTC)
Received: from mail-ig0-x236.google.com (mail-ig0-x236.google.com
 [IPv6:2607:f8b0:4001:c05::236])
 (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits))
 (Client CN "smtp.gmail.com",
 Issuer "Google Internet Authority G2" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 5299B9AC;
 Mon, 15 Dec 2014 23:01:35 +0000 (UTC)
Received: by mail-ig0-f182.google.com with SMTP id hn15so6007050igb.15
 for <multiple recipients>; Mon, 15 Dec 2014 15:01:34 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=mime-version:sender:in-reply-to:references:from:date:message-id
 :subject:to:cc:content-type;
 bh=V72h16qr9VefIhyxNPmm9b1zDEE9h29XxVf+CJX9nX4=;
 b=lakPOGiGM/3yznAZqaic7kL5QCVedHP7TTY1noPRx0KQpxJFIGruwlc9xZwipSbmrk
 sA0vghdpUzhi/KIAZOVljhIjy2Gv+IEpO+k5TJ2kJadplpn0VIyjeTwPGmR8kkN3rf5g
 rYdgVgSMZQsmKCI3u+Vlh4aWIs0pyflApiQbZnhdgFey+N4MlsaYRU0hv3XglEN4yiEN
 fbZL7OCpomQgpTS4ZZKYNiEH4g+9PcwTXMUVn/vGEcODG/gjpHRzmbgHiLHfOfuSxBmi
 uS5jCM239ddVuiEJIjWjbYycD4MVNjTsExMJDNrgIv42u5xWCdwQVbj+M+Fkuvehgt1k
 u4NQ==
X-Received: by 10.107.158.70 with SMTP id h67mr10109502ioe.37.1418684494753;
 Mon, 15 Dec 2014 15:01:34 -0800 (PST)
MIME-Version: 1.0
Sender: carpeddiem@gmail.com
Received: by 10.107.0.85 with HTTP; Mon, 15 Dec 2014 15:01:14 -0800 (PST)
In-Reply-To: <548F6107.7030509@freebsd.org>
References: <201412151425.sBFEPhhs009026@svn.freebsd.org>
 <CAG=rPVc3GJpCGSBUD4-TgfKG2HVHt=oEr71G_twChx6_x7tBGQ@mail.gmail.com>
 <CAPyFy2D3GHFk=daKia6psn-TjjtGthzAiYHghVuPk778nXqZrw@mail.gmail.com>
 <CAG=rPVd1-aOiG=f8em03jC9CbEvb_NeTaQa+bpmzL+8U+NC2Lw@mail.gmail.com>
 <548F6107.7030509@freebsd.org>
From: Ed Maste <emaste@freebsd.org>
Date: Mon, 15 Dec 2014 18:01:14 -0500
X-Google-Sender-Auth: KcWDCQ4ExglwTpA5Ijo5Tam3d_E
Message-ID: <CAPyFy2BkqeL06BfHhHo_n2aK5qLGTMu=y1rJT=kMpP7e-H3PmQ@mail.gmail.com>
Subject: Re: svn commit: r275804 - head/gnu/usr.bin/cc/cc1plus
To: Alfred Perlstein <alfred@freebsd.org>
Content-Type: text/plain; charset=UTF-8
Cc: Craig Rodrigues <rodrigc@freebsd.org>,
 "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>,
 "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>,
 "src-committers@freebsd.org" <src-committers@freebsd.org>
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 15 Dec 2014 23:01:35 -0000

>>   Also, not removing temporary files upon failure
>> makes things easier to debug.
>
> +100

In general I agree completely. In this case though such a change would
just create an empty temporary file upon failure, which provides no
additional help in tracking down the failure over the "gperf: not
found" error that is already emitted.