From owner-freebsd-current@FreeBSD.ORG Tue Mar 23 14:05:09 2010 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4D6DE106566B for ; Tue, 23 Mar 2010 14:05:09 +0000 (UTC) (envelope-from nwhitehorn@freebsd.org) Received: from argol.doit.wisc.edu (argol.doit.wisc.edu [144.92.197.212]) by mx1.freebsd.org (Postfix) with ESMTP id 220CB8FC30 for ; Tue, 23 Mar 2010 14:05:08 +0000 (UTC) MIME-version: 1.0 Content-transfer-encoding: 7BIT Content-type: text/plain; CHARSET=US-ASCII; format=flowed Received: from avs-daemon.smtpauth3.wiscmail.wisc.edu by smtpauth3.wiscmail.wisc.edu (Sun Java(tm) System Messaging Server 7u2-7.05 32bit (built Jul 30 2009)) id <0KZQ00912N4KPQ00@smtpauth3.wiscmail.wisc.edu>; Tue, 23 Mar 2010 09:05:08 -0500 (CDT) Received: from comporellon.tachypleus.net ([unknown] [76.210.69.218]) by smtpauth3.wiscmail.wisc.edu (Sun Java(tm) System Messaging Server 7u2-7.05 32bit (built Jul 30 2009)) with ESMTPSA id <0KZQ007HKN4HXU30@smtpauth3.wiscmail.wisc.edu>; Tue, 23 Mar 2010 09:05:06 -0500 (CDT) Date: Tue, 23 Mar 2010 09:05:04 -0500 From: Nathan Whitehorn To: FreeBSD-CURRENT Mailing List Message-id: <4BA8CA90.80208@freebsd.org> X-Spam-Report: AuthenticatedSender=yes, SenderIP=76.210.69.218 X-Spam-PmxInfo: Server=avs-12, Version=5.5.5.374460, Antispam-Engine: 2.7.1.369594, Antispam-Data: 2010.3.23.135427, SenderIP=76.210.69.218 User-Agent: Thunderbird 2.0.0.24 (X11/20100320) Cc: Marcel Moolenaar Subject: Re: [PATCH] rename COMPAT_FREEBSD32 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Mar 2010 14:05:09 -0000 > On Mar 22, 2010, at 10:52 AM, David O'Brien wrote: > >>/ On Mon, Mar 15, 2010 at 09:00:18AM -0700, Julian Elischer wrote: />>>/ I certainly agree.. can it be changed please? />>/ />>/ I've waited a while to see what other opinions would be expressed on this />>/ topic. I believe there is sufficient support to rename COMPAT_FREEBSD32 />>/ to something else based on responses in the mailing lists. />>/ />>/ I am sorry if some may wish to label this a "bikeshead". But we seem to />>/ have many folks disliking "COMPAT_FREEBSD32". />>/ />>/ />>/ Based on responses to the topic of COMPAT_FREEBSD32, the following />>/ were the suggestions offered: />>/ COMPAT_ARCH32, COMPAT_ARCH_32BIT, COMPAT_32BIT_ARCH, COMPAT_32BIT, />>/ COMPAT_FREEBSD32BIT /> > There's probably a bigger problem than just how we name it. The option > really encodes 2 independent aspects: > 1. Support for a 32-bit ABI (i.e. ILP32) > 2. Support for a particular OS in ILP32. > > Of course 2 implies 1. > > For example: > COMPAT_IA32 in sys/ia64/ia64/machdep.c enabled code to save and restore > IA32 registers as part of cpu_switch(). In this context COMPAT_IA32 was > perfectly named. It's now called COMPAT_FREEBSD32, which doesn't make a > lot of sense because what if I only want to support Linux/ia32 and not > FreeBSD/ia32 (or vice-versa if you club them under a single COMPAT_*32)? The original version of my my patch had this split, with a COMPAT_FREEBSD32 and a COMPAT_[IA/PPC/MIPS]32. The problem is that the 32-bit FreeBSD compat is deeply intertwined with providing support for any 32-bit binaries at all (e.g., the 32-bit linuxolator depends on calling into it), so it isn't actually possible to support having COMPAT_LINUX32 without COMPAT_FREEBSD32 without a huge amount of work. So I scrapped that in favor of the unified name only, and we ended up with COMPAT_FREEBSD32. In any event, given the persistent interest and consolidation around COMPAT_ARCH32, I'm fine changing the name. -Nathan