From owner-cvs-src@FreeBSD.ORG Sat May 24 10:23:35 2008 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A95061065674; Sat, 24 May 2008 10:23:35 +0000 (UTC) (envelope-from bz@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 9CB018FC1E; Sat, 24 May 2008 10:23:35 +0000 (UTC) (envelope-from bz@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id m4OANZIR031138; Sat, 24 May 2008 10:23:35 GMT (envelope-from bz@repoman.freebsd.org) Received: (from bz@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id m4OANZ2P031137; Sat, 24 May 2008 10:23:35 GMT (envelope-from bz) Message-Id: <200805241023.m4OANZ2P031137@repoman.freebsd.org> From: "Bjoern A. Zeeb" Date: Sat, 24 May 2008 10:23:35 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_7 Cc: Subject: cvs commit: src/sys/dev/bge if_bge.c if_bgereg.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 24 May 2008 10:23:35 -0000 bz 2008-05-24 10:23:35 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) sys/dev/bge if_bge.c if_bgereg.h Log: MFC: if_bgereg.h rev. 1.79 if_bge.c rev. 1.205, 1.209, 1.210 Summary: In some situations we were not clearing pending link state attentions. Because of this we were not getting further interrupts for link state changes, thus never went into iface UP state and thus could not transmit. The only way out of this was an incoming packet generating an rx interrupt and making us call into bge_link_upd. What we do now is force an interrupt at the end of bge_ifmedia_upd_locked so we will call bge_link_upd, clear the link state attention and get further interrupts. While the initial version was not expected to work with all chips the later update in rev. 1.210 is. PR: kern/111804 Tested by: phk, scottl (initial version) Thanks for your help to: davidch, Broadcom Revision Changes Path 1.198.2.7 +34 -2 src/sys/dev/bge/if_bge.c 1.73.2.2 +4 -0 src/sys/dev/bge/if_bgereg.h