From owner-freebsd-current@FreeBSD.ORG Tue Mar 23 14:28:02 2010 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id AD62C106579A; Tue, 23 Mar 2010 14:28:02 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id 5BCFB8FC0A; Tue, 23 Mar 2010 14:28:01 +0000 (UTC) Received: from bigwig.baldwin.cx (66.111.2.69.static.nyinternet.net [66.111.2.69]) by cyrus.watson.org (Postfix) with ESMTPSA id 06F0146B90; Tue, 23 Mar 2010 10:28:01 -0400 (EDT) Received: from jhbbsd.localnet (smtp.hudson-trading.com [209.249.190.9]) by bigwig.baldwin.cx (Postfix) with ESMTPA id 2CBE98A021; Tue, 23 Mar 2010 10:28:00 -0400 (EDT) From: John Baldwin To: freebsd-current@freebsd.org Date: Tue, 23 Mar 2010 10:20:46 -0400 User-Agent: KMail/1.12.1 (FreeBSD/7.3-CBSD-20100217; KDE/4.3.1; amd64; ; ) References: <20100322175213.GA87475@dragon.NUXI.org> <18331E07-2DEA-43C7-A0BF-5B3A2E827FDB@mac.com> In-Reply-To: <18331E07-2DEA-43C7-A0BF-5B3A2E827FDB@mac.com> MIME-Version: 1.0 Message-Id: <201003231020.46887.jhb@freebsd.org> Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.0.1 (bigwig.baldwin.cx); Tue, 23 Mar 2010 10:28:00 -0400 (EDT) X-Virus-Scanned: clamav-milter 0.95.1 at bigwig.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-1.7 required=4.2 tests=AWL,BAYES_00 autolearn=ham version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on bigwig.baldwin.cx Cc: Marcel Moolenaar Subject: Re: [PATCH] rename COMPAT_FREEBSD32 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Mar 2010 14:28:02 -0000 On Monday 22 March 2010 4:48:19 pm Marcel Moolenaar wrote: > > On Mar 22, 2010, at 10:52 AM, David O'Brien wrote: > > > On Mon, Mar 15, 2010 at 09:00:18AM -0700, Julian Elischer wrote: > >> I certainly agree.. can it be changed please? > > > > I've waited a while to see what other opinions would be expressed on this > > topic. I believe there is sufficient support to rename COMPAT_FREEBSD32 > > to something else based on responses in the mailing lists. > > > > I am sorry if some may wish to label this a "bikeshead". But we seem to > > have many folks disliking "COMPAT_FREEBSD32". > > > > > > Based on responses to the topic of COMPAT_FREEBSD32, the following > > were the suggestions offered: > > COMPAT_ARCH32, COMPAT_ARCH_32BIT, COMPAT_32BIT_ARCH, COMPAT_32BIT, > > COMPAT_FREEBSD32BIT > > There's probably a bigger problem than just how we name it. The option > really encodes 2 independent aspects: > 1. Support for a 32-bit ABI (i.e. ILP32) > 2. Support for a particular OS in ILP32. > > Of course 2 implies 1. > > For example: > COMPAT_IA32 in sys/ia64/ia64/machdep.c enabled code to save and restore > IA32 registers as part of cpu_switch(). In this context COMPAT_IA32 was > perfectly named. It's now called COMPAT_FREEBSD32, which doesn't make a > lot of sense because what if I only want to support Linux/ia32 and not > FreeBSD/ia32 (or vice-versa if you club them under a single COMPAT_*32)? For amd64 I think COMPAT_LINUX32 requires COMPAT_FREEBSD32 in practice for this reason. If you did make them independent, I would prefer that the code use things like '#if defined(COMPAT_FREEBSD32) || defined(COMPAT_LINUX32)' instead of requiring the user to specify both COMPAT_IA32 and COMPAT_(FREEBSD32|LINUX32). BTW, in that context COMPAT_FREEBSD32 looks far more consistent than other alternatives suggested. I think all of the names have various pros and cons and that changing it is more hassle than its worth. My one suggestion to Nathan was to move COMPAT_FREEBSD32 in GENERIC on amd64 so it is not immediately next to COMPAT_FREEBSD to reduce confusion. -- John Baldwin