From owner-svn-src-all@FreeBSD.ORG Wed Jan 19 08:00:27 2011 Return-Path: Delivered-To: svn-src-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D0601106566B; Wed, 19 Jan 2011 08:00:27 +0000 (UTC) (envelope-from peterjeremy@acm.org) Received: from fallbackmx08.syd.optusnet.com.au (fallbackmx08.syd.optusnet.com.au [211.29.132.10]) by mx1.freebsd.org (Postfix) with ESMTP id 4A4558FC16; Wed, 19 Jan 2011 08:00:26 +0000 (UTC) Received: from mail34.syd.optusnet.com.au (mail34.syd.optusnet.com.au [211.29.133.218]) by fallbackmx08.syd.optusnet.com.au (8.13.1/8.13.1) with ESMTP id p0J5udlT007393; Wed, 19 Jan 2011 16:56:39 +1100 Received: from server.vk2pj.dyndns.org (c220-239-116-103.belrs4.nsw.optusnet.com.au [220.239.116.103]) by mail34.syd.optusnet.com.au (8.13.1/8.13.1) with ESMTP id p0J5uZaX021605 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 19 Jan 2011 16:56:36 +1100 X-Bogosity: Ham, spamicity=0.000000 Received: from server.vk2pj.dyndns.org (localhost.vk2pj.dyndns.org [127.0.0.1]) by server.vk2pj.dyndns.org (8.14.4/8.14.4) with ESMTP id p0J5uZdi091041; Wed, 19 Jan 2011 16:56:35 +1100 (EST) (envelope-from peter@server.vk2pj.dyndns.org) Received: (from peter@localhost) by server.vk2pj.dyndns.org (8.14.4/8.14.4/Submit) id p0J5uZb5091040; Wed, 19 Jan 2011 16:56:35 +1100 (EST) (envelope-from peter) Date: Wed, 19 Jan 2011 16:56:35 +1100 From: Peter Jeremy To: John Baldwin Message-ID: <20110119055635.GA90983@server.vk2pj.dyndns.org> References: <201101181523.p0IFNGeB042079@svn.freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="rwEMma7ioTxnRzrJ" Content-Disposition: inline In-Reply-To: <201101181523.p0IFNGeB042079@svn.freebsd.org> X-PGP-Key: http://members.optusnet.com.au/peterjeremy/pubkey.asc User-Agent: Mutt/1.5.20 (2009-06-14) Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r217538 - in head/sys/dev: buslogic cs X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Jan 2011 08:00:27 -0000 --rwEMma7ioTxnRzrJ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 2011-Jan-18 15:23:16 +0000, John Baldwin wrote: >Log: > Remove some always-true comparisons. =2E.. >--- head/sys/dev/cs/if_cs.c Tue Jan 18 14:58:44 2011 (r217537) >+++ head/sys/dev/cs/if_cs.c Tue Jan 18 15:23:16 2011 (r217538) >@@ -364,7 +364,7 @@ cs_cs89x0_probe(device_t dev) >=20 > if (!error && !(sc->flags & CS_NO_IRQ)) { > if (chip_type =3D=3D CS8900) { >- if (irq >=3D 0 || irq < 16) >+ if (irq < 16) > irq =3D cs8900_irq2eeint[irq]; > else > irq =3D 255; Irrespective of the signedness or otherwise of "irq", I'm fairly certain that '||' should have been '&&' before. --=20 Peter Jeremy --rwEMma7ioTxnRzrJ Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.15 (FreeBSD) iEYEARECAAYFAk02fRMACgkQ/opHv/APuIcsmQCggV/6tmuYKpkcgsSM9/XGvRwh HfEAnA1Zxh0rptCg9lEITD24IJDSnrFx =HmtV -----END PGP SIGNATURE----- --rwEMma7ioTxnRzrJ--