From owner-freebsd-ports-bugs@FreeBSD.ORG Wed Jul 25 10:50:12 2012 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C57FE1065670 for ; Wed, 25 Jul 2012 10:50:12 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id A502D8FC0C for ; Wed, 25 Jul 2012 10:50:12 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q6PAoCL6005383 for ; Wed, 25 Jul 2012 10:50:12 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q6PAoCxK005382; Wed, 25 Jul 2012 10:50:12 GMT (envelope-from gnats) Date: Wed, 25 Jul 2012 10:50:12 GMT Message-Id: <201207251050.q6PAoCxK005382@freefall.freebsd.org> To: freebsd-ports-bugs@FreeBSD.org From: Michael Scheidell Cc: Subject: Re: ports/170010: [UPDATE] chinese/fcitx and its addons to 4.2.5 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Michael Scheidell List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Jul 2012 10:50:12 -0000 The following reply was made to PR ports/170010; it has been noted by GNATS. From: Michael Scheidell To: , Cc: Subject: Re: ports/170010: [UPDATE] chinese/fcitx and its addons to 4.2.5 Date: Wed, 25 Jul 2012 06:41:22 -0400 --------------080609050504020403080604 Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit almost. ls CHANGES MOVED Tools patch-data_CMakeLists.txt.orig COPYRIGHT Makefile UIDs security GIDs Mk UPDATING KNOBS README chinese LEGAL Templates patch-data_CMakeLists.txt seems that (for some reason), it puts the NEW patch file in ../ and does not follow index. (i did: cd /usr/ports patch -EuN -I -i /tmp/patch.txt, and it (i hope) put all but the new patch in the right dir (see above) from now on, you must put EACH PORT in its own attachment, and list the fact that you are patching four different ports. or, you must open 4 prn's and make sure you let the ocmmitter know to link them together. If you think this is too much work, consider the committer has to split your patch apart, guess which patch goes where, and, due to this, a committer who takes a quick glance at your pr's will most likely skip by it to get one that is easier to work. lets try that next time, I don't know if send-pr can attach 4 different patches, but it seems that Index. -- Michael Scheidell, CTO o: 561-999-5000 d: 561-948-2259 >*| *SECNAP Network Security Corporation * Best Mobile Solutions Product of 2011 * Best Intrusion Prevention Product * Hot Company Finalist 2011 * Best Email Security Product * Certified SNORT Integrator ______________________________________________________________________ This email has been scanned and certified safe by SpammerTrap(r). For Information please see http://www.spammertrap.com/ ______________________________________________________________________ --------------080609050504020403080604 Content-Type: text/html; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit almost.

ls
CHANGES                MOVED                Tools                patch-data_CMakeLists.txt.orig
COPYRIGHT            Makefile            UIDs                security
GIDs                Mk                UPDATING
KNOBS                README                chinese
LEGAL                Templates            patch-data_CMakeLists.txt


seems that (for some reason), it puts the NEW patch file in ../ and does not follow index.

(i did:
cd /usr/ports
patch -EuN -I -i /tmp/patch.txt, and it (i hope) put all but the new patch in the right dir (see above)

from now on, you must put EACH PORT in its own attachment, and list the fact that you are patching four different ports.  or, you must open 4 prn's and make sure you let the ocmmitter know to link them together.

If you think this is too much work, consider the committer has to split your patch apart, guess which patch goes where, and, due to this, a committer who takes a quick glance at your pr's will most likely skip by it to get one that is easier to work.

lets try that next time, I don't know if send-pr can attach 4 different patches, but it seems that Index.


--
Michael Scheidell, CTO
o: 561-999-5000
d: 561-948-2259
> | SECNAP Network Security Corporation
  • Best Mobile Solutions Product of 2011
  • Best Intrusion Prevention Product
  • Hot Company Finalist 2011
  • Best Email Security Product
  • Certified SNORT Integrator

This email has been scanned and certified safe by SpammerTrap®.
For Information please see http://www.spammertrap.com/

--------------080609050504020403080604--