From owner-cvs-all@FreeBSD.ORG Tue Sep 25 17:03:54 2007 Return-Path: Delivered-To: cvs-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id AF35216A41A; Tue, 25 Sep 2007 17:03:54 +0000 (UTC) (envelope-from alc@cs.rice.edu) Received: from mail.cs.rice.edu (mail.cs.rice.edu [128.42.1.31]) by mx1.freebsd.org (Postfix) with ESMTP id 1F43713C459; Tue, 25 Sep 2007 17:03:53 +0000 (UTC) (envelope-from alc@cs.rice.edu) Received: from mail.cs.rice.edu (localhost.localdomain [127.0.0.1]) by mail.cs.rice.edu (Postfix) with ESMTP id 7BF592C2CA1; Tue, 25 Sep 2007 11:45:24 -0500 (CDT) X-Virus-Scanned: by amavis-2.4.0 at mail.cs.rice.edu Received: from mail.cs.rice.edu ([127.0.0.1]) by mail.cs.rice.edu (mail.cs.rice.edu [127.0.0.1]) (amavisd-new, port 10024) with LMTP id fJZbrG7M0tfx; Tue, 25 Sep 2007 11:45:11 -0500 (CDT) Received: from adsl-216-63-78-18.dsl.hstntx.swbell.net (adsl-216-63-78-18.dsl.hstntx.swbell.net [216.63.78.18]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.cs.rice.edu (Postfix) with ESMTP id F3EA42C2C96; Tue, 25 Sep 2007 11:45:10 -0500 (CDT) Message-ID: <46F93B16.50102@cs.rice.edu> Date: Tue, 25 Sep 2007 11:45:10 -0500 From: Alan Cox User-Agent: Thunderbird 2.0.0.6 (X11/20070819) MIME-Version: 1.0 To: Rink Springer References: <200709250625.l8P6P7w7082233@repoman.freebsd.org> <20070925110147.GC60963@rink.nu> In-Reply-To: <20070925110147.GC60963@rink.nu> Content-Type: multipart/mixed; boundary="------------000403060704050604080507" Cc: Alan Cox , cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/amd64/include vmparam.h src/sys/arm/include vmparam.h src/sys/i386/include vmparam.h src/sys/ia64/include vmparam.h src/sys/kern kern_exec.c vfs_bio.c src/sys/powerpc/include vmparam.h src/sys/sparc64/include ... X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Sep 2007 17:03:54 -0000 This is a multi-part message in MIME format. --------------000403060704050604080507 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Rink Springer wrote: > Hi Alan, > > On Tue, Sep 25, 2007 at 06:25:07AM +0000, Alan Cox wrote: > >> Change the management of cached pages (PQ_CACHE) in two fundamental >> ways: >> > > With this change, KDE no longer starts up; the process 'kbuildsycoca' > seems to wait forever in status 'madvpo'. Reverting this changeset fixes > the problem. > > This is a problem with madvise(WILLNEED). I believe that the attached patch will fix it. Thanks, Alan --------------000403060704050604080507 Content-Type: text/plain; name="vm_object_madvise.patch" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="vm_object_madvise.patch" Index: vm/vm_object.c =================================================================== RCS file: /home/ncvs/src/sys/vm/vm_object.c,v retrieving revision 1.383 diff -p -u -r1.383 vm_object.c --- vm/vm_object.c 25 Sep 2007 06:25:06 -0000 1.383 +++ vm/vm_object.c 25 Sep 2007 16:17:40 -0000 @@ -1105,7 +1105,8 @@ shadowlookup: /* * If the page is cached, reactivate it. */ - m = vm_page_alloc(tobject, tpindex, VM_ALLOC_IFCACHED); + m = vm_page_alloc(tobject, tpindex, VM_ALLOC_IFCACHED | + VM_ALLOC_NOBUSY); } if (m == NULL) { /* --------------000403060704050604080507--