From owner-freebsd-ports  Wed Nov 14 14:40: 7 2001
Delivered-To: freebsd-ports@hub.freebsd.org
Received: from freefall.freebsd.org (freefall.FreeBSD.org [216.136.204.21])
	by hub.freebsd.org (Postfix) with ESMTP id 21A9537B418
	for <freebsd-ports@hub.freebsd.org>; Wed, 14 Nov 2001 14:40:04 -0800 (PST)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.11.4/8.11.4) id fAEMe4E80488;
	Wed, 14 Nov 2001 14:40:04 -0800 (PST)
	(envelope-from gnats)
Date: Wed, 14 Nov 2001 14:40:04 -0800 (PST)
Message-Id: <200111142240.fAEMe4E80488@freefall.freebsd.org>
To: freebsd-ports@FreeBSD.org
Cc: 
From: AMAKAWA Shuhei <sa264@cam.ac.uk>
Subject: Re: ports/31208: Fix bugs in net/generic-nqs.  Now it really works!
Reply-To: AMAKAWA Shuhei <sa264@cam.ac.uk>
Sender: owner-freebsd-ports@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-ports.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-ports>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-ports>
X-Loop: FreeBSD.org

The following reply was made to PR ports/31208; it has been noted by GNATS.

From: AMAKAWA Shuhei <sa264@cam.ac.uk>
To: tonym@biolateral.com.au
Cc: freebsd-gnats-submit@FreeBSD.org, tom@FreeBSD.org,
	Tony Maher <tonymaher@optushome.com.au>
Subject: Re: ports/31208: Fix bugs in net/generic-nqs.  Now it really works!
Date: Wed, 14 Nov 2001 22:31:19 +0000

 Thank you very much for reviewing the pr.
 
 > >      files/patch-ai fixes the bug which caused removal of jobs from a pipe
 > >      queue when all the inbound-load-balanced queues that follow it are 
 > >      busy.
 > 
 > Looks correct to me but I do not have a network to test with at the moment.
 > interconn is required on BSD systems (see patch-aa).
 > Actually I'd suggest that this patch-ai be modified to do error checking
 > as in patch-aa
 > 
 >     if (interconn () < 0) {
 >         fprintf (stderr, "%s(FATAL): Unable to get ", Nqsmgr_prefix);
 >         fprintf (stderr, "a pipe to the local daemon.\n");
 >         exit (16);
 >     }
 
 Looks good to me, although I haven't tested.
 My fix (without your error checking) has been working fine and you
 could trust me about that.  The addition of the error checking
 shouldn't affect that.
 
 
 > Please commit.
 
 Please do.
 
 --
 Shuhei

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message