From owner-freebsd-current@FreeBSD.ORG Mon Apr 12 16:50:22 2004 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C7C1016A4D6; Mon, 12 Apr 2004 16:50:22 -0700 (PDT) Received: from rwcrmhc11.comcast.net (rwcrmhc11.comcast.net [204.127.198.35]) by mx1.FreeBSD.org (Postfix) with ESMTP id 915C343D41; Mon, 12 Apr 2004 16:50:22 -0700 (PDT) (envelope-from julian@elischer.org) Received: from interjet.elischer.org ([24.7.73.28]) by comcast.net (rwcrmhc11) with ESMTP id <2004041223502101300fffr4e>; Mon, 12 Apr 2004 23:50:22 +0000 Received: from localhost (localhost.elischer.org [127.0.0.1]) by InterJet.elischer.org (8.9.1a/8.9.1) with ESMTP id QAA12632; Mon, 12 Apr 2004 16:50:20 -0700 (PDT) Date: Mon, 12 Apr 2004 16:50:18 -0700 (PDT) From: Julian Elischer To: Tim Robbins In-Reply-To: <20040412233701.GA71177@cat.robbins.dropbear.id.au> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII cc: FreeBSD current users Subject: Re: JKH project.. X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Apr 2004 23:50:22 -0000 On Tue, 13 Apr 2004, Tim Robbins wrote: > On Sun, Apr 11, 2004 at 03:51:45PM -0700, Julian Elischer wrote: > > > Junior kernel hacker project.. > > > > the fork syscall has to check the new PID against all exixting pids.. > > > > here's the current code.. when teh PID-space starts becoming > > "fragmented.." this starts to take "real time". > [...] > > with several thousand processes, forking a lot, this starts to take > > a 'noticable' amount of time. > > I've been using a hashtable-based PID allocator for the last few months. > I didn't have enough time to run any serious benchmarks, so I never > committed it. If the amount of time is noticeable in your environment, > would you mind trying the patch below? > > > > > Suggestions welcome.. :-) > Well what you've done seems to fit my definition of "improved".. anyone got comments? You are sure you have all the cases when session, (etc) code handles a dead session leader etc.? > >