From owner-freebsd-doc@FreeBSD.ORG Tue Jan 17 09:37:27 2006 Return-Path: X-Original-To: freebsd-doc@FreeBSD.org Delivered-To: freebsd-doc@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6CAAF16A424 for ; Tue, 17 Jan 2006 09:37:27 +0000 (GMT) (envelope-from dougb@dougbarton.us) Received: from mail2.fluidhosting.com (mail2.fluidhosting.com [204.14.90.12]) by mx1.FreeBSD.org (Postfix) with SMTP id 3038643D49 for ; Tue, 17 Jan 2006 09:37:26 +0000 (GMT) (envelope-from dougb@dougbarton.us) Received: (qmail 71566 invoked by uid 399); 17 Jan 2006 09:37:25 -0000 Received: from localhost (HELO ?192.168.0.3?) (dougb@dougbarton.us@127.0.0.1) by localhost with SMTP; 17 Jan 2006 09:37:25 -0000 Message-ID: <43CCBAD3.5060006@dougbarton.us> Date: Tue, 17 Jan 2006 01:37:23 -0800 From: Doug Barton User-Agent: Thunderbird 1.5 (X11/20060112) MIME-Version: 1.0 To: pav@FreeBSD.org References: <43CC529C.2080800@dougbarton.us> <1137488520.38904.18.camel@pav.hide.vol.cz> In-Reply-To: <1137488520.38904.18.camel@pav.hide.vol.cz> X-Enigmail-Version: 0.94.0.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit Cc: freebsd-doc@FreeBSD.org Subject: Re: Request for review, rc.d-related updates for handbook X-BeenThere: freebsd-doc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Documentation project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Jan 2006 09:37:27 -0000 Pav Lucistnik wrote: > Doug Barton píše v po 16. 01. 2006 v 18:12 -0800: > >> I've gone through the handbook and updated a few areas related to the rc.d >> new world order, and would appreciate review, especially for style, of my >> patch, since it's been a while since I've done anything beyond simple doc work. > >> http://people.freebsd.org/~dougb/doc-rc.d.diff > > Watch whitespace, you converted leading tab to eight-spaces on one > place. Fixed. > + rcd section, > perhaps ">rc.d instead? Ah, yes. I had already fixed the other two, as I agreed with your opinion here. I just fixed this one too. > Regarding Porter's Handbook patch, what's wrong with opening the text > with "Startup scripts"? They don't only control services at startup. > It's general text and more clear to reader than > "rc.d scripts". Wtf are "rc.d scripts". I'm definitely open to a better suggestion here. > Don't use term before you explain it. Generally I agree with you, however this is not the section that defines this topic, that's done in the handbook. However, I'm still open to better ideas here. > + %%X11BASE%% macros is strongly encouraged as well. > I'm not sure these are really "macros" - they are more expansions or > replacements. OK, I subbed "expansion" here. > - Integration with &man.rcorder.8; is available by using > - USE_RCORDER instead of > - USE_RC_SUBR. > Why you deleted this block? It's still valid for 6.0-R and older - we do > support ports on older -STABLE branches. Put it back and perhaps add > "Prior to &os; 6.1-RELEASE, " ? I added what you suggested, along with a mention that this is deprecated (which was the reason for removing it). I really don't want people to depend on this, as it doesn't do what I think people think it does. > + and the latter sets one if the variable is unset OR null. > If the OR is ment as an emphasis, use docbook markup instead of capital > letters. OK. > - value of USE_RC_SUBR and > - USE_RCORDER are automatically added to > + value of USE_RC_SUBR > + are automatically added to the > Again, why this change? See above. Thanks for this feedback, I've uploaded a new version of the patch with the changes you suggested incorporated. Doug -- If you're never wrong, you're not trying hard enough