From owner-freebsd-bugs  Tue Oct 15 13:50:10 2002
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id C2A9F37B419
	for <freebsd-bugs@hub.freebsd.org>; Tue, 15 Oct 2002 13:50:02 -0700 (PDT)
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 196EF43EAA
	for <freebsd-bugs@hub.freebsd.org>; Tue, 15 Oct 2002 13:50:02 -0700 (PDT)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.12.6/8.12.6) with ESMTP id g9FKo1Co042755
	for <freebsd-bugs@freefall.freebsd.org>; Tue, 15 Oct 2002 13:50:01 -0700 (PDT)
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.12.6/8.12.6/Submit) id g9FKo1cg042754;
	Tue, 15 Oct 2002 13:50:01 -0700 (PDT)
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id BA31237B401
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 15 Oct 2002 13:42:55 -0700 (PDT)
Received: from fafoe.dyndns.org (chello212186121237.14.vie.surfer.at [212.186.121.237])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 455FB43FA1
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 15 Oct 2002 13:42:53 -0700 (PDT)
	(envelope-from stefan@fafoe.dyndns.org)
Received: by frog.fafoe (Postfix, from userid 1001)
	id 28F802C6; Tue, 15 Oct 2002 22:42:51 +0200 (CEST)
Message-Id: <20021015204251.28F802C6@frog.fafoe>
Date: Tue, 15 Oct 2002 22:42:51 +0200 (CEST)
From: Stefan Farfeleder <e0026813@stud3.tuwien.ac.at>
Reply-To: Stefan Farfeleder <e0026813@stud3.tuwien.ac.at>
To: FreeBSD-gnats-submit@FreeBSD.org
X-Send-Pr-Version: 3.113
Subject: kern/44121: [PATCH] bogus cast removal in hea driver
Sender: owner-freebsd-bugs@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-bugs.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-bugs>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-bugs>
X-Loop: FreeBSD.org


>Number:         44121
>Category:       kern
>Synopsis:       [PATCH] bogus cast removal in hea driver
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Tue Oct 15 13:50:01 PDT 2002
>Closed-Date:
>Last-Modified:
>Originator:     Stefan Farfeleder
>Release:        FreeBSD 5.0-CURRENT i386
>Organization:
>Environment:
FreeBSD frog.fafoe 5.0-CURRENT FreeBSD 5.0-CURRENT #0: Thu Oct 3 21:27:04 CEST 2002 freebsd@frog.fafoe:/freebsd/current/obj/freebsd/current/src/sys/FROG i386

	
>Description:
The current code casts vct (which hat type VCI_Table *) to a uintptr_t and then
passes the integer to bzero that wants a void *. 
	
>How-To-Repeat:
make buildkernel
[...]
/freebsd/current/src/sys/dev/hea/eni_vcm.c:289: warning: passing arg 1 of pointer to function makes pointer from integer without a cast

	
>Fix:
Just remove the cast.

Index: eni_vcm.c
===================================================================
RCS file: /home/ncvs/src/sys/dev/hea/eni_vcm.c,v
retrieving revision 1.10
diff -u -r1.10 eni_vcm.c
--- eni_vcm.c	19 Apr 2002 17:43:11 -0000	1.10
+++ eni_vcm.c	15 Oct 2002 20:10:53 -0000
@@ -286,7 +286,7 @@
 	/*
 	 * Reset everything
 	 */
-	bzero ( (uintptr_t)vct, sizeof(VCI_Table) );
+	bzero ( vct, sizeof(VCI_Table) );
 
 	return ( err );
 }
>Release-Note:
>Audit-Trail:
>Unformatted:

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message