From owner-freebsd-dtrace@FreeBSD.ORG  Fri Aug 23 18:50:32 2013
Return-Path: <owner-freebsd-dtrace@FreeBSD.ORG>
Delivered-To: freebsd-dtrace@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTP id C85C4F05;
 Fri, 23 Aug 2013 18:50:32 +0000 (UTC)
 (envelope-from hiren.panchasara@gmail.com)
Received: from mail-ea0-x22e.google.com (mail-ea0-x22e.google.com
 [IPv6:2a00:1450:4013:c01::22e])
 (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id C382E2B76;
 Fri, 23 Aug 2013 18:50:31 +0000 (UTC)
Received: by mail-ea0-f174.google.com with SMTP id z15so448469ead.5
 for <multiple recipients>; Fri, 23 Aug 2013 11:50:30 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=mime-version:in-reply-to:references:date:message-id:subject:from:to
 :cc:content-type;
 bh=OrgPzddQtJihucr5G0Ej/FFUVGFgZhq9zV66P4utY0I=;
 b=PRzs/OrPdudPcloTsCQ3ZKAzGV9THhFq2s+6pekAEXXP6o63w43xd/BBMwMJQWBlyY
 RigP2/BrWw/l/39CMm5r9AEuGVxuLDlUgpIZAMiA9b5sSqvI/b4d+HTI1w0mcXxkkI18
 W2CRkHeR1I6tsjw3/2P8X2QkiOYf2Lf1lUR7YuCec1147ayPU3KWz73sPHgRjDxAAiKb
 l19O1HJ6GmfJeKxbL8YE+eh9s4VfU+pxwe1Y7l953oNfpTwtcT3c2x9SR4fWFiKxeMCf
 8YO0SGEfF3m22PV2UPqbI3l3hZEEY03arrrMqdiFkOyqJYYQ0dJiRiBJ+ijcn22OewFk
 zhRQ==
MIME-Version: 1.0
X-Received: by 10.14.173.4 with SMTP id u4mr714895eel.81.1377283830014; Fri,
 23 Aug 2013 11:50:30 -0700 (PDT)
Received: by 10.14.105.137 with HTTP; Fri, 23 Aug 2013 11:50:29 -0700 (PDT)
In-Reply-To: <CALCpEUEZYLs0D3ufW4mKRybqgGKcX98+VGbnWWRHnRVRo0XDmQ@mail.gmail.com>
References: <20130821045926.GA17196@raichu>
 <5CA94104-0489-4DD2-8EC2-D42FF7339E39@freebsd.org>
 <CALCpEUEZYLs0D3ufW4mKRybqgGKcX98+VGbnWWRHnRVRo0XDmQ@mail.gmail.com>
Date: Fri, 23 Aug 2013 11:50:29 -0700
Message-ID: <CALCpEUFiAVe6Yj7Tqpzm-09G2Zn0POukF6_P7NHZbL8uGcvOQw@mail.gmail.com>
Subject: Re: DTrace network providers
From: hiren panchasara <hiren.panchasara@gmail.com>
To: George Neville-Neil <gnn@freebsd.org>
Content-Type: text/plain; charset=UTF-8
X-Content-Filtered-By: Mailman/MimeDel 2.1.14
Cc: "freebsd-net@freebsd.org" <freebsd-net@freebsd.org>,
 freebsd-dtrace@freebsd.org
X-BeenThere: freebsd-dtrace@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: "A discussion list for developers working on DTrace in FreeBSD."
 <freebsd-dtrace.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-dtrace>, 
 <mailto:freebsd-dtrace-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-dtrace>
List-Post: <mailto:freebsd-dtrace@freebsd.org>
List-Help: <mailto:freebsd-dtrace-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-dtrace>,
 <mailto:freebsd-dtrace-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 23 Aug 2013 18:50:33 -0000

On Thu, Aug 22, 2013 at 10:25 AM, hiren panchasara <
hiren.panchasara@gmail.com> wrote:

>
>
>
> On Thu, Aug 22, 2013 at 8:36 AM, George Neville-Neil <gnn@freebsd.org>wrote:
>
>>
>> On Aug 21, 2013, at 1:00 , Mark Johnston <markj@freebsd.org> wrote:
>>
>> > Hello!
>> >
>> > I've ported the ip, tcp and udp DTrace providers to FreeBSD, following
>> > the Solaris documentation here:
>> >
>> > https://wikis.oracle.com/display/DTrace/ip+Provider
>> > https://wikis.oracle.com/display/DTrace/tcp+Provider
>> > https://wikis.oracle.com/display/DTrace/udp+Provider
>> >
>> > My implementation of these providers makes use of dynamic translators,
>> > for which FreeBSD support was added in r254468; this patch won't compile
>> > with earlier revisions. The use of dynamic translators means that
>> > existing DTrace scripts which use these providers will just work when
>> run
>> > on FreeBSD - no modifications needed. In particular, all of the examples
>> > in the links above will work properly on FreeBSD with my diff.
>> >
>> > I've collected a bunch of example scripts for these providers and placed
>> > them here:
>> >
>> > http://people.freebsd.org/~markj/dtrace/network-providers/
>> >
>> > To run one you just need to execute "dtrace -s <script>".
>> >
>> > In general these providers make it trivial to monitor or count packets
>> > and bytes on a per-host/port/protocol/interface basis. One can also do
>> > neat things like watch TCP connection state transitions in real time
>> > (tcpstate.d) and measure connection latency. All of the probes
>> > correspond to logical events in their respective protocol
>> > implementations; all of the providers have send and receive probes, and
>> > the tcp provider has a few more.
>> >
>> > I didn't have to make any major changes to add support for these
>> > providers, but I've made a few small tweaks:
>> >
>> > 1. Add a little helper function for TCP state changes instead of
>> >   sprinkling a bunch of SDT_PROBE calls throughout the code.
>> > 2. Set the IPv6 payload size in TCP and UDP before calling ip6_output().
>> >   This is done for the send probes so that the ipinfo_t argument
>> >   can be used to get the payload size. It's not quite correct since it
>> >   doesn't include the length of IPv6 option headers (they aren't known
>> >   yet), but I think that's ok for the purposes of these providers.
>> > 3. Set the IPv4 header version in udp_output(). This is already done for
>> >   IPv6.
>> >
>> > I'm hoping that none of this (or the rest of the diff) is controversial,
>> > but I wanted to make sure, so any review would be really appreciated.
>> >
>> > The patch is here:
>> >
>> >
>> http://people.freebsd.org/~markj/patches/network-providers/network-providers-1.diff
>> >
>> > It depends on r254468. To use it, just recompile the kernel (assuming
>> > that KDTRACE_HOOKS is enabled) and copy
>> > $SRC/cddl/lib/libdtrace/{ip,tcp,udp}.d (added by the patch) to
>> > /usr/lib/dtrace. Then the example scripts I linked above should just
>> > work.
>> >
>>
>> Excellent work.  I'll test these today.
>>
>
> +1. Great work.
>
> Updating my laptop right now to test.
>

Tried a bunch of basic things and it works great!

Thanks again.
Hiren

>
> cheers,
> Hiren
>