From owner-svn-ports-all@FreeBSD.ORG  Sun Dec  8 21:40:00 2013
Return-Path: <owner-svn-ports-all@FreeBSD.ORG>
Delivered-To: svn-ports-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 372CEED;
 Sun,  8 Dec 2013 21:40:00 +0000 (UTC)
Received: from ainaz.pair.com (ainaz.pair.com [209.68.2.66])
 by mx1.freebsd.org (Postfix) with ESMTP id 0B4AB11A0;
 Sun,  8 Dec 2013 21:39:59 +0000 (UTC)
Received: from tuna.dhcp.nue.suse.com (charybdis-ext.suse.de [195.135.221.2])
 by ainaz.pair.com (Postfix) with ESMTPSA id 5BB313F429;
 Sun,  8 Dec 2013 16:39:58 -0500 (EST)
Date: Sun, 8 Dec 2013 22:39:57 +0100 (CET)
From: Gerald Pfeifer <gerald@pfeifer.com>
To: Kozlov Sergey <kozlov.sergey.404@gmail.com>
Subject: Re: svn commit: r335189 - in head/print/pdftk: . files
In-Reply-To: <529C7599.1050509@gmail.com>
Message-ID: <alpine.LNX.2.00.1312082235050.2197@tuna.site>
References: <201311291548.rATFm8g7098382@svn.freebsd.org>
 <alpine.LNX.2.00.1312012257230.2185@tuna.site>
 <C89CD972357B819FE03015D6@atuin.in.mat.cc> <529C7599.1050509@gmail.com>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Cc: Mathieu Arnold <mat@FreeBSD.org>, Greg Larkin <glarkin@FreeBSD.org>,
 svn-ports-all@freebsd.org, svn-ports-head@freebsd.org,
 ports-committers@freebsd.org
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 08 Dec 2013 21:40:00 -0000

On Mon, 2 Dec 2013, Kozlov Sergey wrote:
>>|>    - Added LIB_DEPENDS. Libraries provided by gcc required to run the
>>|>    binary, but gcc is registered only as build dependency. Removing the
>>|>      gcc after installation of pdftk is permitted but breaks pdftk
>>| This looks quite dubious since USE_GCC already takes care of
>>| registering this run-time dependency.
>>|
>>| USE_GCC also takes care of the BUILD_DEPENDency, so the pre-existing
>>| entry there also is unnecessary.
>> Hum, does GCC always come with gcj ? I thought it did not, that's why there
>> was an explicit dependency on it.
> 1. GCC does not always come with gcj, user can compile the port without 
> it. So pdftk needs both gcc and gcj to build, and they are added 
> explicitly as build dependencies.

Except that this won't work.  If USE_GCC=yes did not already include
GCJ, then just rebuilding the port, with the same (saved) options will
not make a difference.

> 2. USE_GCC register GCC (and not gcj) only as build dependency, so 
> additional lib-dependencies are required.

The current dependencies added by your are really, really bogus:

  LIB_DEPENDS=	libgcj.so:${PORTSDIR}/lang/gcc${CSUFF} \
		libstdc++.so:${PORTSDIR}/lang/gcc${CSUFF} \
		libgcc_s.so:${PORTSDIR}/lang/gcc${CSUFF}

If you insist on libgcj.so, I can accept that, but then let's drop
the other two least.  This is definitely covered by USE_GCC=yes.

  BUILD_DEPENDS=gcj${CSUFF}:${PORTSDIR}/lang/gcc${CSUFF} \
		gcjh${CSUFF}:${PORTSDIR}/lang/gcc${CSUFF} \
		cpp${CSUFF}:${PORTSDIR}/lang/gcc${CSUFF}

And here just pick one of gcj or gcjh, that is sufficient and in
line what we usually do.

And remove the dependency on cpp, since again this is covered by
USE_GCC=yes.


Can I go ahead and just make that 

  LIB_DEPENDS=    libgcj.so:${PORTSDIR}/lang/gcc${CSUFF}
  BUILD_DEPENDS=  gcj${CSUFF}:${PORTSDIR}/lang/gcc${CSUFF}

?

Gerald