From owner-freebsd-bugs@FreeBSD.ORG  Thu Aug 11 13:23:34 2005
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
X-Original-To: freebsd-bugs@freebsd.org
Delivered-To: freebsd-bugs@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id DFE7A16A41F
	for <freebsd-bugs@freebsd.org>; Thu, 11 Aug 2005 13:23:34 +0000 (GMT)
	(envelope-from ah@crypta.net)
Received: from mail.crypta.net (mail.crypta.net [83.136.131.3])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 8B24243D45
	for <freebsd-bugs@freebsd.org>; Thu, 11 Aug 2005 13:23:33 +0000 (GMT)
	(envelope-from ah@crypta.net)
Received: by mail.crypta.net (cryptobank/eProtect-smtpd, from userid 1001)
	id 484DEECD403; Thu, 11 Aug 2005 15:18:03 +0200 (CEST)
Date: Thu, 11 Aug 2005 15:18:02 +0200
From: Andy Hilker <ah@crypta.net>
To: freebsd-bugs@freebsd.org
Message-ID: <20050811131802.GA9462@mail.crypta.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.4.2.1i
X-PGP-Key: http://wwwkeys.pgp.net:11371/pks/lookup?op=get&search=0xEC6E1071
X-PGP-Fingerprint: 9B2E 5892 AD93 D5C5 FB8E  3912 35D6 951B EC6E 1071
Organization: cryptobank - Andy Hilker
Subject: rc-ng problem and kernel threaded procs = [procname]
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 11 Aug 2005 13:23:35 -0000

Hi,

i think I have found a problem with rc-ng scripts and procnames
with brackets (e.g. kernel threads!).

Brackets [] are ignored, process will not be found and is regarded
as "not running". This breaks stop,status functions of rcng. The
following patch allows brackets in variable procname rc-ng scripts.
Maybe someone can review and fix this issue.

It was relevant for me when using [mysqld].

bye,
Andy


# $FreeBSD: src/etc/rc.subr,v 1.31.2.1 2005/01/17 11:51:00 keramida Exp $
--- rc.subr     Thu Aug 11 15:18:52 2005
+++ /etc/rc.subr        Thu Aug 11 15:14:06 2005
@@ -267,7 +267,7 @@
                _procnamebn=${_procname##*/}
                _fp_args='_arg0 _argv'
                _fp_match='case "$_arg0" in
-                   $_procname|$_procnamebn|${_procnamebn}:|"(${_procnamebn})")'
+                   "$_procname"|$_procnamebn|${_procnamebn}:|"(${_procnamebn})")'
        fi
 
        _proccheck='