From owner-svn-src-head@FreeBSD.ORG Wed Jul 21 10:14:06 2010 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0C28E1065670; Wed, 21 Jul 2010 10:14:06 +0000 (UTC) (envelope-from attilio@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c]) by mx1.freebsd.org (Postfix) with ESMTP id 072DF8FC19; Wed, 21 Jul 2010 10:14:05 +0000 (UTC) Received: from svn.freebsd.org (localhost [127.0.0.1]) by svn.freebsd.org (8.14.3/8.14.3) with ESMTP id o6LAE4Ai085530; Wed, 21 Jul 2010 10:14:04 GMT (envelope-from attilio@svn.freebsd.org) Received: (from attilio@localhost) by svn.freebsd.org (8.14.3/8.14.3/Submit) id o6LAE4QR085528; Wed, 21 Jul 2010 10:14:04 GMT (envelope-from attilio@svn.freebsd.org) Message-Id: <201007211014.o6LAE4QR085528@svn.freebsd.org> From: Attilio Rao Date: Wed, 21 Jul 2010 10:14:04 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org X-SVN-Group: head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Subject: svn commit: r210337 - head/sys/kern X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Jul 2010 10:14:06 -0000 Author: attilio Date: Wed Jul 21 10:14:04 2010 New Revision: 210337 URL: http://svn.freebsd.org/changeset/base/210337 Log: Probabilly defaulting to KTR_GEN is not the right decision when KTR_MASK is not defined at all because KTR_GEN is still a valid class and some traces may fit in. Default to 0, instead, and block any tracing. As long as this is a POLA violation (some thirdy-part code, even if that may be a questionable choice, could be rely on that feature) a MFC possibility might be carefully evaluated. Sponsored by: Sandvine Incorporated Modified: head/sys/kern/kern_ktr.c Modified: head/sys/kern/kern_ktr.c ============================================================================== --- head/sys/kern/kern_ktr.c Wed Jul 21 10:11:46 2010 (r210336) +++ head/sys/kern/kern_ktr.c Wed Jul 21 10:14:04 2010 (r210337) @@ -65,7 +65,7 @@ __FBSDID("$FreeBSD$"); #endif #ifndef KTR_MASK -#define KTR_MASK (KTR_GEN) +#define KTR_MASK (0) #endif #ifndef KTR_CPUMASK