From owner-cvs-all@FreeBSD.ORG Tue Sep 25 19:43:47 2007 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id DF28816A417; Tue, 25 Sep 2007 19:43:47 +0000 (UTC) (envelope-from rink@rink.nu) Received: from mx1.rink.nu (thunderstone.rink.nu [80.112.228.34]) by mx1.freebsd.org (Postfix) with ESMTP id 7DFB413C46A; Tue, 25 Sep 2007 19:43:47 +0000 (UTC) (envelope-from rink@rink.nu) Received: from localhost (localhost [127.0.0.1]) by mx1.rink.nu (Postfix) with ESMTP id 1B3FD6D439; Tue, 25 Sep 2007 21:43:46 +0200 (CEST) X-Virus-Scanned: amavisd-new at rink.nu Received: from mx1.rink.nu ([127.0.0.1]) by localhost (thunderstone.rink.nu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id tmJJPCemoSBu; Tue, 25 Sep 2007 21:43:39 +0200 (CEST) Received: by mx1.rink.nu (Postfix, from userid 1000) id 74B386D438; Tue, 25 Sep 2007 21:43:39 +0200 (CEST) Date: Tue, 25 Sep 2007 21:43:39 +0200 From: Rink Springer To: Kostik Belousov Message-ID: <20070925194339.GA91097@rink.nu> References: <200709250625.l8P6P7w7082233@repoman.freebsd.org> <20070925110147.GC60963@rink.nu> <46F93B16.50102@cs.rice.edu> <20070925171204.GJ87366@deviant.kiev.zoral.com.ua> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070925171204.GJ87366@deviant.kiev.zoral.com.ua> User-Agent: Mutt/1.5.13 (2006-08-11) Cc: Rink Springer , Alan Cox , cvs-src@freebsd.org, Alan Cox , cvs-all@freebsd.org, src-committers@freebsd.org Subject: Re: cvs commit: src/sys/amd64/include vmparam.h src/sys/arm/include vmparam.h src/sys/i386/include vmparam.h src/sys/ia64/include vmparam.h src/sys/kern kern_exec.c vfs_bio.c src/sys/powerpc/include vmparam.h src/sys/sparc64/include ... X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Sep 2007 19:43:48 -0000 On Tue, Sep 25, 2007 at 08:12:04PM +0300, Kostik Belousov wrote: > On Tue, Sep 25, 2007 at 11:45:10AM -0500, Alan Cox wrote: > > Rink Springer wrote: > > >Hi Alan, > > > > > >On Tue, Sep 25, 2007 at 06:25:07AM +0000, Alan Cox wrote: > > > > > >> Change the management of cached pages (PQ_CACHE) in two fundamental > > >> ways: > > >> > > > > > >With this change, KDE no longer starts up; the process 'kbuildsycoca' > > >seems to wait forever in status 'madvpo'. Reverting this changeset fixes > > >the problem. > > > > > > > > > > This is a problem with madvise(WILLNEED). I believe that the attached > > patch will fix it. > > > > Thanks, > > Alan > > > > > > > > > Index: vm/vm_object.c > > =================================================================== > > RCS file: /home/ncvs/src/sys/vm/vm_object.c,v > > retrieving revision 1.383 > > diff -p -u -r1.383 vm_object.c > > --- vm/vm_object.c 25 Sep 2007 06:25:06 -0000 1.383 > > +++ vm/vm_object.c 25 Sep 2007 16:17:40 -0000 > > @@ -1105,7 +1105,8 @@ shadowlookup: > > /* > > * If the page is cached, reactivate it. > > */ > > - m = vm_page_alloc(tobject, tpindex, VM_ALLOC_IFCACHED); > > + m = vm_page_alloc(tobject, tpindex, VM_ALLOC_IFCACHED | > > + VM_ALLOC_NOBUSY); > > } > > if (m == NULL) { > > /* > > Yes, this indeed fixes the problem. Several minutes ago I suggested the > same change to rdivacky@, and he reported that the problem is gone. Same case here - feel free to get it committed, if you aren't already working on this. Alan, thanks for the quick response! -- Rink P.W. Springer - http://rink.nu "root is always right" -- the kernel