From owner-freebsd-current Tue Nov 3 22:12:09 1998 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id WAA26569 for freebsd-current-outgoing; Tue, 3 Nov 1998 22:12:09 -0800 (PST) (envelope-from owner-freebsd-current@FreeBSD.ORG) Received: from whistle.com (s205m131.whistle.com [207.76.205.131]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id WAA26564 for ; Tue, 3 Nov 1998 22:12:05 -0800 (PST) (envelope-from archie@whistle.com) Received: (from smap@localhost) by whistle.com (8.7.5/8.6.12) id WAA22223; Tue, 3 Nov 1998 22:11:55 -0800 (PST) Received: from bubba.whistle.com(207.76.205.7) by whistle.com via smap (V1.3) id sma022219; Tue Nov 3 22:11:34 1998 Received: (from archie@localhost) by bubba.whistle.com (8.8.7/8.6.12) id WAA20667; Tue, 3 Nov 1998 22:11:34 -0800 (PST) From: Archie Cobbs Message-Id: <199811040611.WAA20667@bubba.whistle.com> Subject: Re: Current 'make world' warnings cleanup In-Reply-To: <199811040541.VAA18498@austin.polstra.com> from John Polstra at "Nov 3, 98 09:41:24 pm" To: jdp@polstra.com (John Polstra) Date: Tue, 3 Nov 1998 22:11:34 -0800 (PST) Cc: ryany@pobox.com, current@FreeBSD.ORG X-Mailer: ELM [version 2.4ME+ PL38 (25)] MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG John Polstra writes: > > I'm not 100% certain if this is the right place to be asking this, but: > > I noticed on the FreeBSD projects page that running a make world with extra > > warnings enabled, and then clean up the warnings, although not a high priority > > project, would be a good thing to do. > > > > Well, seeing as how my count of all instances of ' warning: ' within my log > > of my most recent make world totals to about 85,000 lines, I figure this > > might be as good a place as any to burn my weekend/weeknight time. > > Sounds good. Just one thing: don't fall prey to the temptation to > fix all the pointer mismatch warnings by blindly inserting casts just > to make the compiler shut up. That's a common mistake, and as often > as not it simply hides the real problem from the compiler rather than > fixing it. Another gotcha when doing this.. often "unused variable" warnings happen because there is a variable declared that is only used when certain #ifdef's are true. The solution in these cases is not to remove the variable, but to enclose it's declaration within equivalent #ifdef's.. -Archie ___________________________________________________________________________ Archie Cobbs * Whistle Communications, Inc. * http://www.whistle.com To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message