From owner-svn-src-all@FreeBSD.ORG Tue Apr 28 20:39:22 2009 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 562E3106564A; Tue, 28 Apr 2009 20:39:22 +0000 (UTC) (envelope-from emaste@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c]) by mx1.freebsd.org (Postfix) with ESMTP id 4403E8FC1C; Tue, 28 Apr 2009 20:39:22 +0000 (UTC) (envelope-from emaste@FreeBSD.org) Received: from svn.freebsd.org (localhost [127.0.0.1]) by svn.freebsd.org (8.14.3/8.14.3) with ESMTP id n3SKdMks059366; Tue, 28 Apr 2009 20:39:22 GMT (envelope-from emaste@svn.freebsd.org) Received: (from emaste@localhost) by svn.freebsd.org (8.14.3/8.14.3/Submit) id n3SKdMpl059365; Tue, 28 Apr 2009 20:39:22 GMT (envelope-from emaste@svn.freebsd.org) Message-Id: <200904282039.n3SKdMpl059365@svn.freebsd.org> From: Ed Maste Date: Tue, 28 Apr 2009 20:39:22 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-6@freebsd.org X-SVN-Group: stable-6 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Subject: svn commit: r191637 - stable/6/libexec/rtld-elf X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Apr 2009 20:39:22 -0000 Author: emaste Date: Tue Apr 28 20:39:21 2009 New Revision: 191637 URL: http://svn.freebsd.org/changeset/base/191637 Log: MFC r155084: Fix a malloc overrun in 32-bit compat libmap lookup code. Modified: stable/6/libexec/rtld-elf/ (props changed) stable/6/libexec/rtld-elf/libmap.c Modified: stable/6/libexec/rtld-elf/libmap.c ============================================================================== --- stable/6/libexec/rtld-elf/libmap.c Tue Apr 28 20:36:07 2009 (r191636) +++ stable/6/libexec/rtld-elf/libmap.c Tue Apr 28 20:39:21 2009 (r191637) @@ -263,14 +263,12 @@ lm_findn (const char *p, const char *f, { char pathbuf[64], *s, *t; - if (n < sizeof(pathbuf) - 1) { - memcpy(pathbuf, f, n); - pathbuf[n] = '\0'; + if (n < sizeof(pathbuf) - 1) s = pathbuf; - } else { + else s = xmalloc(n + 1); - strcpy(s, f); - } + memcpy(s, f, n); + s[n] = '\0'; t = lm_find(p, s); if (s != pathbuf) free(s);